-
Notifications
You must be signed in to change notification settings - Fork 707
[css-text][text-spacing] Propose to make allow-end
as the default behavior for the line end
#9521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Closed as Duplicate
Commenter Satisfied
Commenter has indicated satisfaction with the resolution / edits.
css-text-4
Testing Unnecessary
Memory aid - issue doesn't require tests
Comments
The current default behavior of line-end was my suggestion: However, it is fine to me changing this default, as I commented in #9511 (comment). |
allow-end
as the default behavior for the line enndallow-end
as the default behavior for the line end
The change adopted in #9511 means that the initial value is now |
Yes, thank you. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 14, 2024
This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Jan 14, 2024
This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1246972}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 14, 2024
This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1246972}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 14, 2024
This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1246972}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jan 16, 2024
…ogic, a=testonly Automatic update from web-platform-tests [text-spacing-trim] Implement line-end logic This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1246972} -- wpt-commits: 05918d61fbde7aee1ffaf7211be717eed86f6c5a wpt-pr: 43987
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Jan 19, 2024
…ogic, a=testonly Automatic update from web-platform-tests [text-spacing-trim] Implement line-end logic This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <kojiichromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1246972} -- wpt-commits: 05918d61fbde7aee1ffaf7211be717eed86f6c5a wpt-pr: 43987 UltraBlame original commit: 7d719f9becadf1e6df9c290629594bf433b9bb25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Jan 19, 2024
…ogic, a=testonly Automatic update from web-platform-tests [text-spacing-trim] Implement line-end logic This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <kojiichromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1246972} -- wpt-commits: 05918d61fbde7aee1ffaf7211be717eed86f6c5a wpt-pr: 43987 UltraBlame original commit: 7d719f9becadf1e6df9c290629594bf433b9bb25
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Jan 19, 2024
…ogic, a=testonly Automatic update from web-platform-tests [text-spacing-trim] Implement line-end logic This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <kojiichromium.org> Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Kent Tamura <tkentchromium.org> Cr-Commit-Position: refs/heads/main{#1246972} -- wpt-commits: 05918d61fbde7aee1ffaf7211be717eed86f6c5a wpt-pr: 43987 UltraBlame original commit: 7d719f9becadf1e6df9c290629594bf433b9bb25
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 23, 2024
This patch implements the line-end logic of `text-spacing-trim` by applying the kerning only if it would not fit, as per the resolutions at: * w3c/csswg-drafts#9521 * w3c/csswg-drafts#9736 Bug: 1463891 Change-Id: I7b5b2ae43f47ce13c6eaad55a973292e82cc264f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191602 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1246972}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closed as Duplicate
Commenter Satisfied
Commenter has indicated satisfaction with the resolution / edits.
css-text-4
Testing Unnecessary
Memory aid - issue doesn't require tests
Currently, the default behavior of line-end for the
text-spacing-trim
property is defined as:If the author specifies the
allow-end
:From the dogfood feedback, I'd like to propose to change the default behavior to
allow-end
. We can add a value for the current default behavior if needed.This proposal is because when you're typing in editable content. The current default behavior trims the last character as you type, making them difficult to distinguish whether it's full-width code point or half-width code point, until users type the next character. Some IMEs on desktop platforms remember which was used last time, making this symptom more difficult.
This happens quite frequently for Japanese/Simplified Chinese/Korean, where the comma and full stops (periods) are in the "closing" shape. Not as frequent for Traditional Chinese.
I don't know the motivation and the past discussions to make the current behavior as the default. If it has big reasons and the WG decided to make a trade-off, could someone please share?
From my current perspective, the feedback looks reasonable to me, and the difference between the current default and
allow-end
looks hardly noticeable, so this looks like a reasonable change.Thoughts? /cc @fantasai @frivoal @nt1m @vitorroriz @Clqsin45 @MurakamiShinyu @himorin @kidayasuo
The text was updated successfully, but these errors were encountered: