-
Notifications
You must be signed in to change notification settings - Fork 707
[css-inline-3] Requiring authors to declare two values for text-box-edge
is a mistake
#11460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The resolution was made not because it was better, but because we didn't have data which is more intuitive. By requiring two values:
I think everyone agrees that reverting is better, but there's no consensus on "instead default like this" yet. Though, I agree that requiring
? |
Oh yes,
Ok! Let me try to list what the options we could choose:. Option 1:
I believe this is the best option, since Option 2:
This is what I proposed above, but honestly I suggested this under the (wrong) assumption that Option 3: ✨ magic ✨
This is perhaps where this discussion started. It gets at the original idea proposed — make it so authors don't have to think about each edge separately, but rather assume that if someone is trimming to Let's be safe, and make the absence of direction from the author be "hey, you didn't set this, so it goes back to the initial value" — in this case, I'd like to resolve on this soon, and update implementations, so we can teach people how to use the shorthand. Otherwise, authors will have to learn a far more complicated understanding of what's going on. And the early days of teaching a new technology is critical for how it gets cemented in people's minds and taught for many years after. |
Overall, I don't expect this decision will have a large impact, because authors won't usually be turning trimming on when not defining the edge to which to trim (at least not on purpose). |
So you want to redo the discussion at #10703, do I understand correctly? Let's involve @michaeltaranto then. @michaeltaranto said @fanatsai said defaulting to So I guess points we want to discuss are:
Are there any other points we want to discuss?
I heard from CJK authors that |
I think
It's about compatibility for
and if we change to interpret it from |
Yes, that kind of change would break sites, so we need to make a decision and stick with it. I think defaulting to I think I agree with @jensimmons about the problem, though. Requiring both might not have been unreasonable if authors were always setting both, but since they can request trimming only the top edge or only the bottom edge, forcing them to specify both is awkward. |
To summarize: Currently, if an author only includes one value for Instead let's resolve that declaring only one value is valid, and the undeclared edge reverts to This will mean that when the author only includes one value, the following happens:
While making this change could have unintended consequences for the unskilled author (they write Doing this will make using
I do not believe that most use cases for |
The CSS Working Group just discussed
The full IRC log of that discussion<TabAtkins> jensimmons: right now, t-b-e requires an author to specify both values<TabAtkins> jensimmons: if they just say "cap" not "cap auto"/etc, then it's supposed to be invalid, but there's not interop <TabAtkins> jensimmons: i think that's a mistake, i was writing an article in december and foudn it hard to teach because i had to teach the whol elinebox model <TabAtkins> jensimmons: i think we should allow declaring just one and make some assumptions <fantasai> https://github.com//issues/11460#issuecomment-2769319469 <TabAtkins> jensimmons: if they declare cap/edge/alphabetic, we assume the other is auto <florian> The whole model is indeed complex to understand. I support making easy things easy, and letting authors get what they want without needing to understand the whole thing if we can. <TabAtkins> jensimmons: there's a question about.... shouldn't we try to do something more magic for authors? like if you are trimming the cap edge you probably want to also trim the alphabetic edge. this started from an author request to trim both with just one value <TabAtkins> jensimmons: but when i was makign demos, i foudn there are plenty of times you do want to trim to both cap and alphabetic, but there are plenty of times you want to do something different too. so i think we should just default "auto" for the missing one <fantasai> +1 to this proposal from me, I think it makes sense to default to auto <fantasai> s/default/default omitted values/ <florian> s/what they want without/what they probably want without <TabAtkins> astearns: any concern that each individual value expands to the correct two values differently? <TabAtkins> astearns: is that hard to teach, or is it more like any partiuclar author is only using a few of these, and our default expansion for that value is probably what they want <TabAtkins> jensimmons: i think for "text" becoming "text text"/etc I think it's pretty obvious, tho I'd be interested in hearing if someone thinks differently <TabAtkins> jensimmons: you don't in one rule that "ideographic" and "cap". you might mix them on one page, but they'll be on different elements <astearns> ack fantasai <TabAtkins> fantasai: we have a bunch of places where if you *can* duplicate the value, we do, and we do something else if we can't <TabAtkins> astearns: yeah, this is just a little more complex, since you have "auto" sometimes in first, sometimes in second <TabAtkins> fantasai: you're basically default the "other" value. it's like background-position, if you say "left" you get "center left", if you say "top" you get "top center" <kizu> q+ <TabAtkins> jensimmons: question is just if someone is doing ideographic a lot, is "ideographic" alone implying doubled? <TabAtkins> florian: doing it both ways makes the most sense by defualt. i agree with the proposal <TabAtkins> florian: just give people what they likely want by default without having to udnerstand the whole model <astearns> ack kizu <TabAtkins> jensimmons: yeah, just should have a default rather than the current bheavior which is invalid, which doesn't do anything <florian> s/doing it both ways/doing ideographic both ways <TabAtkins> kizu: as an author, if we could have alphabetic/ideographic as shorter keywords, a bit long to write when we have other shorthands like "cap" <TabAtkins> kizu: like "cap a" instead of "cap alphabetic" <TabAtkins> astearns: probably fair, but a separate issue <TabAtkins> +1 to the proposal <TabAtkins> astearns: comments? objections? <TabAtkins> RESOLVED: Allow text-box-edge to take a single keyword, expanding as specified in Jen's final comment |
In October, the CSSWG resolved discussed the behavior when one value is specified for
text-box-edge
, and resolved that "2 values are required unless the single value provided can be doubled".I believe this is a mistake. I've been making lots of demos and this makes the writing code more confusing. I'm also writing an article, and finding it harder to teach the newer spec. My article has become much longer trying to explain it.
I've read the original issue and the CSSWG discussion, but I do not believe the author comment that triggered the change was asking for the change that was made.
Use cases
Let's consider several use cases (demos: https://codepen.io/jensimmons/full/XJrXWKg):
First, imagine the author wants to trim both the top & bottom in order to center the text vertically. They can simply write:
Next, imagine they want to trim the top of a headline to line it up with a floated image. Ideally, they should be able to write:
Currently, this does work in Safari, but the resolution in #10703 means this is supposed to be invalid. Instead authors are supposed to write:
But why? From the author POV, this doesn't really make sense. If I want to trim the top, I write code about the top. Why do I have to also write code about the bottom? The bottom should just be regular… be whatever. I don't know, I'm just changing the top.
It's more work for authors to remember that they have to define an edge for the side they do not want to trim. They have to think through how the non-trimmed side should be defined, even though it won't be altered. And if they forget to do this, their trimming code has no effect.
If I were an author who'd forgotten to include the
text
value intext-box: trim-start cap text
, and I was trying to debug why in the world it doesn't work... it would take a while to realize I need to defined the end edge. I'd waste a lot of time trying to figure out what's wrong with the start edge.Reason for the original resolution
The reason this change was made is because one author suggested that
text-box-edge
be radically redefined to no longer have two edges. They though (presumably only thinking about the Latin alphabet) that "cap" could just always meancap alphabetic
, that "ex" could always meanex alphabetic
, and that CSS could be made more simple by getting rid of the idea that there are two edges to be defined separately.I can see why this seems to make sense. Why not keep things simple? But I can also see why
text-box-edge
is defined with two independent edges. There are many more scripts around the globe, and we must create a system that can support all possible futures — much of which is unknown, since it will require coordination between font metric standards and font makers, as well as expert knowledge of global scripts.Meanwhile the the resolution in #10703 ignored the idea that
text-box-edge
should be changed to only ever have one value, never two. Instead the resolution decided that instead of defaulting the unstated second value totext
, CSS should require authors to explicitly state two values likecap text
orex text
ortext alphabetic
. (This doesn't apply totext
,ideographic
, orideographic-ink
since they are understood to define two sides at once).There's no documented reason for making the unstated second value invalid instead of
text
. It seems like it just felt like a good idea at the time. But once I started writing code, I realized it's not.tl;dr
Let's revert the resolution in #10703 and instead default like this:
text-box-edge: cap
is understood to betext-box-edge: cap text
text-box-edge: ex
is understood to betext-box-edge: ex text
text-box-edge: alphabetic
is understood to betext-box-edge: text alphabetic
etc...
The text was updated successfully, but these errors were encountered: