[cssom-view-1] Add: run snapshot post-layout state steps #10796 #11037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "run snapshot post-layout state steps" as resolved in issue w3c#10796. Let other specifications specify what they snapshot on a feature-by-feature basis.
|
@emilio Does this look like a reasonable approach? HTML would then invoke this step in the appropriate place, and other specs would refer to this and say what they snapshot. |
emilio
approved these changes
Oct 15, 2024
|
|
||
| 1. For each CSS feature that needs to snapshot post-layout state, take a snapshot of the relevant state. | ||
|
|
||
| The state that is snapshot is defined in other specifications. These steps must not invalidate <var>doc</var> or any other {{Document}}s in such a way that other post-layout snapshotting steps can observe that such snapshotting happened. It follows that the order of which such snapshotting takes place should not matter. |
There was a problem hiding this comment.
I don't quite know what the right thing to do is for other specs to reference these kind of things, but be good to have them listed here or something actually... @tabatkins do you know what the best thing to do here is?
There was a problem hiding this comment.
We just need some defined term here for other specs to hook, like <dfn export>snapshotted post-layout state</dfn>.
And fwiw, the "should" in this line needs to be "must".
There was a problem hiding this comment.
I've added the "should" -> "must" to #11056
1b92ee9 to
f0c414f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "run snapshot post-layout state steps" as resolved in issue #10796. Let other specifications specify what they snapshot on a feature-by-feature basis.
Resolution: #10796 (comment)