-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Commit
close #9462
- v2.7.16
- v2.7.16-beta.2
- v2.7.16-beta.1
- v2.7.15
- v2.7.14
- v2.7.13
- v2.7.12
- v2.7.11
- v2.7.10
- v2.7.9
- v2.7.8
- v2.7.7
- v2.7.6
- v2.7.5
- v2.7.4
- v2.7.3
- v2.7.2
- v2.7.1
- v2.7.0
- v2.7.0-beta.8
- v2.7.0-beta.7
- v2.7.0-beta.6
- v2.7.0-beta.5
- v2.7.0-beta.4
- v2.7.0-beta.3
- v2.7.0-beta.2
- v2.7.0-beta.1
- v2.7.0-alpha.12
- v2.7.0-alpha.11
- v2.7.0-alpha.10
- v2.7.0-alpha.9
- v2.7.0-alpha.8
- v2.7.0-alpha.7
- v2.7.0-alpha.6
- v2.7.0-alpha.5
- v2.7.0-alpha.4
- v2.7.0-alpha.3
- v2.7.0-alpha.2
- v2.7.0-alpha.1
- v2.6.14
- v2.6.13
- v2.6.12
- v2.6.11
- v2.6.10
- v2.6.9
- v2.6.8
- v2.6.7
- v2.6.6
- v2.6.5
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,9 +61,17 @@ function add ( | |
const original = handler | ||
handler = original._wrapper = function (e) { | ||
if ( | ||
// no bubbling, should always fire. | ||
// this is just a safety net in case event.timeStamp is unreliable in | ||
// certain weird environments... | ||
e.target === e.currentTarget || | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ericdrobinson
|
||
// event is fired after handler attachment | ||
e.timeStamp >= attachedTimestamp || | ||
// #9462 bail for iOS 9 bug: event.timeStamp is 0 after history.pushState | ||
e.timeStamp === 0 || | ||
// #9448 bail if event is fired in another document in a multi-page | ||
// electron/nw.js app | ||
// electron/nw.js app, since event.timeStamp will be using a different | ||
// starting reference | ||
e.target.ownerDocument !== document | ||
) { | ||
return original.apply(this, arguments) | ||
|
@yyx990803 Can you please explain what this is supposed to do? I'm working in an environment (Adobe CEP-based panels) where this appears to cause button functionality to break. Specifically, it occurs on buttons with images in them. When debugging the
e.target
is, for example, ansvg
whereas thee.currentTarget
is a particulardiv
. This presents as the following problem:The buttons begin to work if the user right-clicks anywhere. This is likely a bug on Adobe's (or the NW.js) side.