new package: wpan-tools-0.9 #53523
new package: wpan-tools-0.9 #53523
Conversation
|
surprised xlint didn't check to see that the file existed, fixed in recent commit though |
|
Hey @paigeadelethompson, the general convention for updates & additions is one commit per pkg, so you may want to squash your commits. |
|
yeah ok I'll see if I can do that Im just heading to bed atm, give me a couple of hours |
8cdfbe4 to
d12aedd
Compare
|
@gmbeard rebased commits I'll remember for next time I'll definitely want to submit some more pkgs |
| checksum=fa76d9c1874220e4b1f91c226f42baf1e372ea8ccf4b892effaf0d164448f608 | ||
|
|
||
| post_install() { | ||
| vlicense COPYING |
There was a problem hiding this comment.
That's only a symlink in their repo, it'd probably better to directly vlicense https://github.com/linux-wpan/wpan-tools/blob/master/LICENSES/ISC.txt I think
There was a problem hiding this comment.
lol dude its a file
/Users/paigethompson/wpan-tools-0.9
❯ tree
.
├── COPYING
├── Makefile.am
├── Makefile.in
├── aclocal.m4
├── build-aux
│ ├── compile
│ ├── config.guess
│ ├── config.sub
│ ├── depcomp
│ ├── install-sh
│ ├── ltmain.sh
│ └── missing
├── config.h.in
├── configure
├── configure.ac
├── examples
│ ├── Makefile.am
│ ├── Makefile.in
│ ├── README.examples
│ ├── TODO
│ ├── af_ieee802154_rx.c
│ ├── af_ieee802154_tx.c
│ ├── af_inet6_rx.c
│ ├── af_inet6_tx.c
│ ├── af_packet_rx.c
│ └── af_packet_tx.c
├── m4
│ ├── libtool.m4
│ ├── ltoptions.m4
│ ├── ltsugar.m4
│ ├── ltversion.m4
│ └── lt~obsolete.m4
├── src
│ ├── Makefile.am
│ ├── Makefile.in
│ ├── info.c
│ ├── interface.c
│ ├── iwpan.c
│ ├── iwpan.h
│ ├── mac.c
│ ├── nl802154.h
│ ├── nl_extras.h
│ ├── phy.c
│ └── sections.c
├── wpan-hwsim
│ ├── Makefile.am
│ ├── Makefile.in
│ ├── mac802154_hwsim.h
│ └── wpan-hwsim.c
└── wpan-ping
├── Makefile.am
├── Makefile.in
├── README.wpan-ping
└── wpan-ping.c
-rw-r--r--@ 1 paigethompson staff 968B Nov 9 2015 COPYING
its a file
❯ cat COPYING
Copyright (c) 2014 Alexander Aring
Copyright (c) 2015 Stefan Schmidt
Code is based on iw tool.
Original Authors:
Copyright (c) 2007, 2008 Johannes Berg
Copyright (c) 2007 Andy Lutomirski
Copyright (c) 2007 Mike Kershaw
Copyright (c) 2008-2009 Luis R. Rodriguez
Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
EDIT: they moved it in the git tree so it will need to get updated for 1.0 I guess
|
The commit message should start with an uppercase N btw. |
|
I'm just noticing that the package hadn't been updated since 2018, although it seems like there have been some commits last year. |
mmmmmm okie yeah that seems important give me a sec |
shrug dont know what to tell you EDIT: I'll see what their plans are for their next release |
d12aedd to
1cfa173
Compare
|
@Bnyro I went ahead and raised the bar, and confirmed this package is indeed being maintained with the intention of reaching a Also one thing I was trying to point out for the linter maybe would be a good idea to improve some of it's checks (does the specified license file actually exist exist, is it a regular file) because I noticed that it will succeed without a warning if the specified file name doesn't exist. Let me know if there's anything else I can do for you here. Much appreciated, |
I think the policy generally is to avoid adding discontinued packages to the repositories, that's why I asked. Looking at that coversation that's not the case for this package though. I'm not a Void Linux maintainer myself, it's just been something I noticed when looking through their Git repo. |
You are assigned as a reviewer, but you're not a maintainer? |
|
Anybody can review pull requests. |
Testing the changes