-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New package: bootterm-0.5 #52797
base: master
Are you sure you want to change the base?
Conversation
I tested a serial console to an x86_64 APU (pcengine). There's a few things I'm not sure about:
|
3e85f21
to
a15e082
Compare
The Makefile is quite simple: But I can't see the cross-build problem, apart maybe for the binary stripping being done in the install target... See the Makefile patch for (random) attempts to fix it Can someone shed some light ? |
# Force termios.h usage instead of asm/termbits.h (for tcgetattr, etc.) | ||
make_build_args="CFLAGS=-DNO_TCGETS2" | ||
short_desc="Simple terminal designed to ease connection to serial ports" | ||
maintainer="Orphaned <orphan@voidlinux.org>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting a package orphaned is bad form, we aren't likely to accept it if you don't want to take basic responsibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tranzystorekk I've since put [WIP]
in the issue title, to express the state of the patch, but maybe I should use [RFC]
instead, WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, I just wanted to make it clear that without a proper contact in the maintainer field this is a non-starter.
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Testing the changes
New package
Local build testing