Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New package: bootterm-0.5 #52797

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

vincele
Copy link
Contributor

@vincele vincele commented Oct 27, 2024

Testing the changes

  • I tested the changes in this PR: briefly

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)

@vincele
Copy link
Contributor Author

vincele commented Oct 27, 2024

I tested a serial console to an x86_64 APU (pcengine).

There's a few things I'm not sure about:

  • make_use_env
  • make_build_args
  • maintainer
  • homepage

@vincele vincele force-pushed the bootterm branch 2 times, most recently from 3e85f21 to a15e082 Compare October 27, 2024 10:02
@vincele
Copy link
Contributor Author

vincele commented Oct 27, 2024

The Makefile is quite simple:
https://github.com/wtarreau/bootterm/blob/master/Makefile

But I can't see the cross-build problem, apart maybe for the binary stripping being done in the install target...

See the Makefile patch for (random) attempts to fix it

Can someone shed some light ?

@vincele vincele changed the title New package: bootterm-0.5 [WIP] New package: bootterm-0.5 Oct 27, 2024
@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Oct 27, 2024
# Force termios.h usage instead of asm/termbits.h (for tcgetattr, etc.)
make_build_args="CFLAGS=-DNO_TCGETS2"
short_desc="Simple terminal designed to ease connection to serial ports"
maintainer="Orphaned <orphan@voidlinux.org>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a package orphaned is bad form, we aren't likely to accept it if you don't want to take basic responsibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tranzystorekk I've since put [WIP] in the issue title, to express the state of the patch, but maybe I should use [RFC] instead, WDYT ?

Copy link
Contributor

@tranzystorekk tranzystorekk Oct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, I just wanted to make it clear that without a proper contact in the maintainer field this is a non-starter.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jan 26, 2025
@vincele vincele marked this pull request as draft January 29, 2025 13:11
@github-actions github-actions bot removed the Stale label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants