-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonic-visualiser: update to 5.2.1 #52406
Open
newbluemoon
wants to merge
2
commits into
void-linux:master
Choose a base branch
from
newbluemoon:sonic-visualiser
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35b21ba
to
f29ac27
Compare
f29ac27
to
808c601
Compare
808c601
to
54cfc68
Compare
2f9e642
to
0f6ff18
Compare
Made a slight modification to the pkg-config-wrapper to find the qt6 tools when cross building on 64 bit host for 32 bit target:
This is the smallest change I could come up with that makes it work, but maybe there's a better solution? |
0f6ff18
to
77d191c
Compare
77d191c
to
31b6109
Compare
31b6109
to
feb2f65
Compare
feb2f65
to
4e657c3
Compare
4e657c3
to
8504486
Compare
instead of lib32 cf. void-linux#52402, make 32-bit cross builds find qt-host-tools on a 64-bit host .pc files contain lib32 hardcoded, lib is a symlink to the corresponding lib{32,64} anyway, so let the wrapper look under lib
8504486
to
5eae531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
There is a problem with 32-bit cross builds on a 64-bit host.
Meson detects Qt6 using pkg-config. However, the corresponding .pc files have
i.e. they have
.../lib32/...
hard coded and so detection of the host tools fails when they are under.../lib64/...
.There are not much options to tweak this; using qmake instead of pkg-config yields the same error.
I think a clean solution would be adjusting Qt6’s .pc files to contain
.../lib/...
solely. There shouldn’t be a problem, becauselib32
andlib64
are symlinks tolib
, anyway. Everything else I can think of would be quite hacky. I don’t know if this is the only package having this problem; I searched for other templates, but didn’t find anything alike.Any ideas/suggestions are very welcome :)