Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New packages: datovka-4.24.2, libdatovka-0.7.0 #41566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

realcharmer
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@realcharmer realcharmer force-pushed the datovka branch 3 times, most recently from 60b8e8f to f0c543a Compare January 10, 2023 20:35
@ghost
Copy link

ghost commented Jan 10, 2023

Fix for libdatovka:

0001-fixup-New-package-libdatovka-0.2.1.txt

Built on x86_64-musl and armv7l-musl (cross).

@Chocimier
Copy link
Member

Please split -devel from library. -devels go to makedepends, library needs gettext-devel-tools in hostmakedepends, application needs qt5-host-tools, then it cross-compiles. On musl it still fails with

aarch64-linux-musl-c++ -c -g -O0 -std=c++11 -O2 -Wall -Wextra -fPIC -I. -I/usr/aarch64-linux-musl/usr/include/libxml2 -I../../.target-spec/linux-g++ -o main.o main.cpp
In file included from main.cpp:11:
/usr/aarch64-linux-musl/usr/include/libdatovka/isds.h:442:5: error: '_Bool' does not name a type; did you mean 'UBool'?
442 | _Bool dbEffectiveOVM; / Box has OVM role (§ 5a) */

discussed at https://www.openwall.com/lists/musl/2017/07/28/1, concluding that C and C++ polyglot headers are hard.

@realcharmer realcharmer force-pushed the datovka branch 2 times, most recently from ae3c47d to 09298e5 Compare January 11, 2023 16:41
@realcharmer
Copy link
Contributor Author

realcharmer commented Jan 11, 2023

Thanks for the tips. I've tried to implement all the suggestions, though datovka on musl still fails to build and now complains about the missing libdatovka library. What have I missed?

@ghost
Copy link

ghost commented Jan 11, 2023

now complains about the missing libdatovka library

Refer to what Chocimier wrote above.

The build system attempts to compile config.tests/libdatovka/main.cpp to check its version.

However, it cannot do so due to the errors in the quote block related to _Bool used by libdatovka. I would rather restrict libdatovka to being glibc-only for the time being.

@realcharmer
Copy link
Contributor Author

Ahhh, I had the impression that your patch would fix musl build. Thanks, I'll restrict the package to glibc.

@realcharmer realcharmer force-pushed the datovka branch 3 times, most recently from 37b0feb to c639905 Compare January 11, 2023 17:15
@realcharmer realcharmer requested a review from a user January 11, 2023 17:29
@paper42 paper42 added the new-package This PR adds a new package label Jan 11, 2023
@realcharmer realcharmer requested a review from a user January 19, 2023 09:26
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I see nothing wrong with this package, but I am afraid I am not the one to make the decision to merge this pull request.

In case you are wondering why your package is not merged, I should instead warn you: this happens with every new package. Package is accepted provided that

  • the submitter is reliable and will maintain the package in the future instead of tossing it to others to deal with it. This wariness was caused by others submitting throwaway packages in the past which quickly became orphaned de-facto.

  • others (i.e. users) have interest in this package due to its demand. I do not know what to describe here.

Or

  • one of the core members or a contributor with access to the repository is interested in this package and will take the responsibility to maintain it in case the submitter does not do its work as a maintainer.

Since you will have to wait for a while, I have a suggestion for you to ask upstream to make libdatovka work on musl.

@realcharmer
Copy link
Contributor Author

Personally I see nothing wrong with this package, but I am afraid I am not the one to make the decision to merge this pull request.

I understand. Perhaps @paper42 might be interested in this package, as it might be relevant for both of us.

Since you will have to wait for a while, I have a suggestion for you to ask upstream to make libdatovka work on musl.

Good idea, I'll bring it up when speaking with the developers.

@realcharmer realcharmer force-pushed the datovka branch 2 times, most recently from 2c57c0d to 521687e Compare February 21, 2023 14:25
@realcharmer realcharmer changed the title New packages: datovka-4.21.1, libdatovka-0.2.1 New packages: datovka-4.22.0, libdatovka-0.3.0 Feb 21, 2023
@realcharmer
Copy link
Contributor Author

I have updated both packages to new release versions. libdatovka seems to still be broken on musl.

@realcharmer
Copy link
Contributor Author

Rebased to current master and updated datovka to version 4.22.1.

@realcharmer
Copy link
Contributor Author

Updated libdatovka to 0.5.1.

@realcharmer realcharmer changed the title New packages: datovka-4.22.1, libdatovka-0.5.1 New packages: datovka-4.23.1, libdatovka-0.5.1 Dec 14, 2023
@realcharmer
Copy link
Contributor Author

Updated datovka to version 4.23.1.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 14, 2024
@realcharmer realcharmer force-pushed the datovka branch 2 times, most recently from 61e7820 to cebf1fa Compare March 22, 2024 12:44
@realcharmer
Copy link
Contributor Author

Updated datovka to version 4.23.6 and libdatovka to 0.6.2.

@realcharmer realcharmer changed the title New packages: datovka-4.23.1, libdatovka-0.5.1 New packages: datovka-4.23.6, libdatovka-0.6.2 Mar 22, 2024
@github-actions github-actions bot removed the Stale label Mar 23, 2024
@realcharmer realcharmer changed the title New packages: datovka-4.23.6, libdatovka-0.6.2 New packages: datovka-4.23.7, libdatovka-0.6.2 Apr 25, 2024
@realcharmer
Copy link
Contributor Author

Updated datovka to version 4.23.7.

Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jul 25, 2024
@realcharmer
Copy link
Contributor Author

Still waiting for merge. Bumping datovka to 4.24.0.

@realcharmer realcharmer changed the title New packages: datovka-4.23.7, libdatovka-0.6.2 New packages: datovka-4.24.0, libdatovka-0.6.2 Jul 26, 2024
@github-actions github-actions bot removed the Stale label Jul 27, 2024
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Oct 25, 2024
@realcharmer realcharmer changed the title New packages: datovka-4.24.0, libdatovka-0.6.2 New packages: datovka-4.24.2, libdatovka-0.7.0 Oct 30, 2024
@realcharmer
Copy link
Contributor Author

@github-actions github-actions bot removed the Stale label Oct 31, 2024
@filiprojek
Copy link
Contributor

Works on my machine, please merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants