-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New packages: datovka-4.24.2, libdatovka-0.7.0 #41566
base: master
Are you sure you want to change the base?
Conversation
60b8e8f
to
f0c543a
Compare
Fix for libdatovka: 0001-fixup-New-package-libdatovka-0.2.1.txt Built on x86_64-musl and armv7l-musl (cross). |
Please split
discussed at https://www.openwall.com/lists/musl/2017/07/28/1, concluding that C and C++ polyglot headers are hard. |
ae3c47d
to
09298e5
Compare
Thanks for the tips. I've tried to implement all the suggestions, though |
Refer to what Chocimier wrote above. The build system attempts to compile However, it cannot do so due to the errors in the quote block related to |
Ahhh, I had the impression that your patch would fix musl build. Thanks, I'll restrict the package to glibc. |
37b0feb
to
c639905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I see nothing wrong with this package, but I am afraid I am not the one to make the decision to merge this pull request.
In case you are wondering why your package is not merged, I should instead warn you: this happens with every new package. Package is accepted provided that
-
the submitter is reliable and will maintain the package in the future instead of tossing it to others to deal with it. This wariness was caused by others submitting throwaway packages in the past which quickly became orphaned de-facto.
-
others (i.e. users) have interest in this package due to its demand. I do not know what to describe here.
Or
- one of the core members or a contributor with access to the repository is interested in this package and will take the responsibility to maintain it in case the submitter does not do its work as a maintainer.
Since you will have to wait for a while, I have a suggestion for you to ask upstream to make libdatovka work on musl.
I understand. Perhaps @paper42 might be interested in this package, as it might be relevant for both of us.
Good idea, I'll bring it up when speaking with the developers. |
2c57c0d
to
521687e
Compare
I have updated both packages to new release versions. libdatovka seems to still be broken on musl. |
Rebased to current master and updated |
Updated |
Updated |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
61e7820
to
cebf1fa
Compare
Updated |
Updated |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
Still waiting for merge. Bumping |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Works on my machine, please merge |
Testing the changes
New package
Local build testing