Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap bind destructuring order: {foo :foo} -> {:foo foo} #152

Merged
merged 1 commit into from
May 2, 2022
Merged

swap bind destructuring order: {foo :foo} -> {:foo foo} #152

merged 1 commit into from
May 2, 2022

Conversation

vito
Copy link
Owner

@vito vito commented May 2, 2022

much easier to read (imo) for deeply nested destructuring

  • top: no destructuring
  • middle: clojure-style (current)
  • bottom: reversed (this PR)

image

note: Clojure needed to swap them to disambiguate :keys, :as, etc. - but Bass eschews those, so it can just use the conventional syntax

@vito vito added the enhancement New feature or request label May 2, 2022
@vito
reverse bind binding order
bf33426 
much easier to read (imo) for deeply nested destructuring
@vito vito merged commit 4ee0b05 into main May 2, 2022
@vito vito deleted the swap-bind branch May 2, 2022 03:43
@vito vito added the breaking Removes or replaces previously supported functionality label May 2, 2022
@vito vito mentioned this pull request May 2, 2022
Merged
5 tasks
@vito vito removed the breaking Removes or replaces previously supported functionality label May 7, 2022
@vito
Copy link
Owner Author

vito commented May 7, 2022

(actually this isn't breaking because binding binds never even shipped)

@vito vito mentioned this pull request May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vito