RecordDotSyntax support

[Avi-D-coder]

Is it possible to add support for expr.lbl and (.lbl) in ormolu prior to RecordDotSyntax coming to GHC? Both forms are implemented in the record-dot-preprocessor and will be in GHC once RecordDotSyntax is implemented.

[neongreen]

Not before they land in the GHC parser.

…

On Tue, Dec 31, 2019, 02:34 Avi Dessauer ***@***.***> wrote: Is it possible to add support for expr.lbl and (.lbl) in ormolu prior to RecordDotSyntax coming to GHC? Both forms are implemented in the record-dot-preprocessor <https://github.com/ndmitchell/record-dot-preprocessor> and will be in GHC once RecordDotSyntax is implemented. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#486?email_source=notifications&email_token=AALT42XRLNRKNH6P7NDCSMTQ3KARDA5CNFSM4KBRBYK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDNNY7A>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALT42QU4EAVJU2PC7YG3XDQ3KARDANCNFSM4KBRBYKQ> .

[neongreen]

My understanding of the preprocessor is that it recognizes certain bits of syntax and substitutes them with HasField methods. However, it does not provide an extended version of the AST that would correspond to Haskell+RecordDotSyntax. So we can't reuse the record-dot-preprocessor code (much).

…

On Tue, Dec 31, 2019, 14:55 Artyom Kazak ***@***.***> wrote: Not before they land in the GHC parser. On Tue, Dec 31, 2019, 02:34 Avi Dessauer ***@***.***> wrote: > Is it possible to add support for expr.lbl and (.lbl) in ormolu prior to > RecordDotSyntax coming to GHC? Both forms are implemented in the > record-dot-preprocessor > <https://github.com/ndmitchell/record-dot-preprocessor> and will be in > GHC once RecordDotSyntax is implemented. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#486?email_source=notifications&email_token=AALT42XRLNRKNH6P7NDCSMTQ3KARDA5CNFSM4KBRBYK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IDNNY7A>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALT42QU4EAVJU2PC7YG3XDQ3KARDANCNFSM4KBRBYKQ> > . >

[Avi-D-coder]

I think I have a workable solution. I'll submit a PR latter today.

[Avi-D-coder]

It works I just have to pass recDotPreOn::Bool derived from DynFlagssrc/Ormolu/Parser.hs into src/Ormolu/Printer/Meat/Declaration/Value.hs. Is the R newtype the place to pass this info?