Add inspection tests to Replicator.elim and V.{make,elim}
#367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For consistency, I added |
aspiwack
approved these changes
Feb 9, 2022
test/Main.hs
Outdated
Comment on lines
29
to
30
| vInspectionTests, | ||
| replicatorInspectionTests |
There was a problem hiding this comment.
Divide this list in two testGroups one for data structure tests, and one for inspection tests.
| [$(inspectTest $ 'elim3 === 'manualElim3)] | ||
|
|
||
| elim3 :: (a %1 -> a %1 -> a %1 -> [a]) %1 -> Replicator a %1 -> [a] | ||
| elim3 f r = Replicator.elim f r |
There was a problem hiding this comment.
Next PR, let's make sure that we can remove the f and the r and still have the inspection test pass.
Tests are now split into "Functional" and "Inspection" groups
14ccb7e to
7bfd57f
Compare
7bfd57f to
83b9184
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicator.elim,V.make, andV.elimare implemented with classes so as to enable inlining. With inspection testing, we need to ensure that their final Core form are the same as a manually unrolled recursion.