Skip to content

Improve shell.nix, add niv, ormolu, and improve CI #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

Improve shell.nix, add niv, ormolu, and improve CI #355

merged 1 commit into from
Jan 14, 2022

Conversation

tbagrel1
Copy link
Member

No description provided.

@tbagrel1 tbagrel1 requested a review from aspiwack January 11, 2022 08:55
aspiwack
aspiwack reviewed Jan 11, 2022
View reviewed changes
@tbagrel1
Copy link
Member Author

Why did you remove the restore-key?

I didn't see that the key and restore-key were different, my bad. By the way, what is github.sha at the end of the primary key?

@aspiwack
Copy link
Member

I didn't see that the key and restore-key were different, my bad. By the way, what is github.sha at the end of the primary key?

It's the commit's hash, I believe.

@tbagrel1 tbagrel1 mentioned this pull request Jan 12, 2022
Merged
@tbagrel1 tbagrel1 force-pushed the tbagrel1/nix-ci-improvements branch 5 times, most recently from aea18d4 to 5749b5a Compare January 13, 2022 17:05
aspiwack
aspiwack approved these changes Jan 13, 2022
View reviewed changes
@tbagrel1
Add niv and ormolu, and improve CI
d0739d1 
The ormolu check in the CI is disabled for now, and will be enabled in a future PR in which the whole codebase will be ormolized.
@tbagrel1 tbagrel1 force-pushed the tbagrel1/nix-ci-improvements branch from d5f4bf6 to d0739d1 Compare January 14, 2022 09:52
@tbagrel1 tbagrel1 changed the title Improve shell.nix, add niv, and format with ormolu Improve shell.nix, add niv, ormolu, and improve CI Jan 14, 2022
@tbagrel1 tbagrel1 merged commit 9b27ec8 into master Jan 14, 2022
@tbagrel1 tbagrel1 deleted the tbagrel1/nix-ci-improvements branch January 14, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspiwack aspiwack aspiwack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbagrel1 @aspiwack