Add a Github action ci #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d65f076 to
92d2eec
Compare
|
Auto-reviewing because I can. Let me just merge. |
32d8b7f to
3d701c3
Compare
|
I chose to make a few adjustments before merging, making my previous comment a lie.
|
Now that we don't need to build GHC ourselves for the sake of linear-base to work, we don't need to lock a super beefy runner for 1h from time to time. On the other hand, the buildkite runner didn't run ci for contributions outside of Tweag. Having a Github-action based ci will be better for contributors.
3d701c3 to
b7284a8
Compare
aspiwack
added a commit
that referenced
this pull request
Apr 9, 2021
It has been obsoleted by the Github-action ci. See #322.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we don't need to build GHC ourselves for the sake of
linear-base to work, we don't need to lock a super beefy runner for 1h
from time to time.
On the other hand, the buildkite runner didn't run ci for
contributions outside of Tweag. Having a Github-action based ci will
be better for contributors.
I'll remove the Buildkite ci in a separate PR.