Skip to content

chore(suite): git ignore vscode settings#7544

Merged
Nodonisko merged 1 commit intodevelopfrom
chore/gitignore-vscode-settings
Feb 7, 2023
Merged

chore(suite): git ignore vscode settings#7544
Nodonisko merged 1 commit intodevelopfrom
chore/gitignore-vscode-settings

Conversation

@PeKne
Copy link
Copy Markdown
Contributor

@PeKne PeKne commented Feb 3, 2023

.vscode/settings.json git ignored. Allow creating customized workspace settings.

@PeKne PeKne requested a review from a team February 3, 2023 14:45
@PeKne PeKne force-pushed the chore/gitignore-vscode-settings branch from b0d2d46 to 318ccbe Compare February 3, 2023 14:52
Comment thread .gitignore Outdated
@PeKne PeKne force-pushed the chore/gitignore-vscode-settings branch from 318ccbe to a313daf Compare February 6, 2023 06:44
Comment thread .vscode/settings.json
@@ -1,36 +0,0 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe don't delete this file? because everyone will need to copy&paste again. I would prefer only ignore it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it is not possible. If you want to ignore a file, it has to be removed first. As described here: https://stackoverflow.com/a/25436481/8332763

@matejkriz
Copy link
Copy Markdown
Member

matejkriz commented Feb 6, 2023

P.S.: VS Code just added Profiles in January Update https://code.visualstudio.com/updates/v1_75#_profiles

@Nodonisko
Copy link
Copy Markdown
Contributor

/rebase

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 7, 2023

`.vscode/` configuration files git ignored. Allows to create customized workspace settings.
@trezor-ci trezor-ci force-pushed the chore/gitignore-vscode-settings branch from 9e096c1 to 179a9c7 Compare February 7, 2023 14:55
@Nodonisko Nodonisko merged commit 7f8fd63 into develop Feb 7, 2023
@Nodonisko Nodonisko deleted the chore/gitignore-vscode-settings branch February 7, 2023 15:03
@tsusanka tsusanka added the chore label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants