removed duplicate code

Author: or-else

app/src/main/java/co/tinode/tindroid/CreateGroupFragment.java

@@ -42,8 +42,6 @@
  * Fragment for adding/editing a group topic
  */
 public class CreateGroupFragment extends Fragment implements UiUtils.AvatarPreviewer {
-
-    private static final String TAG = "CreateGroupFragment";
     private static final int LOADER_ID = 102;
 
     private PromisedReply.FailureListener<ServerMessage> mFailureListener;
@@ -222,10 +220,10 @@ private void createTopic(final Activity activity, final String title, final Bitm
         AttachmentHandler.uploadAvatar(topic.getPub(), avatar, null)
                 .thenApply(new PromisedReply.SuccessListener<ServerMessage>() {
                     @Override
-                    public PromisedReply<ServerMessage> onSuccess(ServerMessage result) {
+                    public PromisedReply<ServerMessage> onSuccess(ServerMessage unused) {
                         return topic.subscribe().thenApply(new PromisedReply.SuccessListener<ServerMessage>() {
                             @Override
-                            public PromisedReply<ServerMessage> onSuccess(ServerMessage result) {
+                            public PromisedReply<ServerMessage> onSuccess(ServerMessage unused) {
                                 for (String user : members) {
                                     topic.invite(user, null /* use default */);
                                 }

app/src/main/java/co/tinode/tindroid/SignUpFragment.java

@@ -184,7 +184,7 @@ public PromisedReply<ServerMessage> onSuccess(ServerMessage ignored_msg) {
                             public PromisedReply<ServerMessage> onSuccess(ServerMessage ignored_msg) {
                                 // Try to create a new account.
                                 MetaSetDesc<VxCard, String> meta = new MetaSetDesc<>(theCard, null);
-                                meta.attachments = theCard.getPhotoAttachment();
+                                meta.attachments = theCard.getPhotoRefs();
                                 return tinode.createAccountBasic(
                                         login, password, true, null, meta,
                                         Credential.append(null, new Credential("email", email)));

app/src/main/java/co/tinode/tindroid/media/VxCard.java

@@ -91,18 +91,6 @@ public void constructBitmap() {
         }
     }
 
-    /**
-     * If Photo is an external reference, return it as a string array with one element.
-     * @return photo URL or null of photo does not exist or is not a reference.
-     */
-    @JsonIgnore
-    public String[] getPhotoAttachment() {
-       if (photo != null && photo.ref != null) {
-           return new String[] { photo.ref };
-       }
-       return null;
-    }
-
     private static Photo serializeBitmap(Bitmap bmp) {
         if (bmp != null) {
             ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();

tinodesdk/src/main/java/co/tinode/tinodesdk/ComTopic.java

@@ -40,7 +40,7 @@ public ComTopic(Tinode tinode, Listener l, boolean isChannel) {
     public PromisedReply<ServerMessage> subscribe() {
         if (isNew()) {
             MetaSetDesc<DP, PrivateType> desc = new MetaSetDesc<>(mDesc.pub, mDesc.priv);
-            if (mDesc.pub != null && mDesc.pub.isPhotoRef()) {
+            if (mDesc.pub != null) {
                 desc.attachments = mDesc.pub.getPhotoRefs();
             }
             return subscribe(new MsgSetMeta<>(desc, null, mTags, null), null);