prevent crash on invalid base64 encoding

Author: or-else

app/src/main/java/co/tinode/tindroid/MediaControl.java

@@ -143,8 +143,13 @@ boolean ensurePlayerReady(final int seq, Map<String, Object> data,
                 return false;
             }
         } else if ((val = data.get("val")) instanceof String) {
-            byte[] source = Base64.decode((String) val, Base64.DEFAULT);
-            mAudioPlayer.setDataSource(new MemoryAudioSource(source));
+            try {
+                byte[] source = Base64.decode((String) val, Base64.DEFAULT);
+                mAudioPlayer.setDataSource(new MemoryAudioSource(source));
+            } catch (IllegalArgumentException ex) {
+                Log.w(TAG, "Unable to play audio: invalid data");
+                Toast.makeText(mContext, R.string.unable_to_play_audio, Toast.LENGTH_SHORT).show();
+            }
         } else {
             mAudioControlCallback.reset();
             Log.w(TAG, "Unable to play audio: missing data");

app/src/main/java/co/tinode/tindroid/UiUtils.java

@@ -1457,11 +1457,20 @@ static public Uri getUriVal(String name, Map<String, Object> data) {
         return url != null ? Uri.parse(url.toString()) : null;
     }
 
+    static public @Nullable byte[] decodeByteArray(Object val) {
+        byte[] bits = null;
+        if (val instanceof String) {
+            try {
+                bits = Base64.decode((String) val, Base64.DEFAULT);
+            } catch (IllegalArgumentException ignored) {}
+        } else {
+            bits = val instanceof byte[] ? (byte[]) val : null;
+        }
+        return bits;
+    }
+
     static public @Nullable byte[] getByteArray(String name, @NotNull Map<String, Object> data) {
-        Object val = data.get(name);
-        return val instanceof String ?
-                Base64.decode((String) val, Base64.DEFAULT) :
-                val instanceof byte[] ? (byte[]) val : null;
+        return decodeByteArray(data.get(name));
     }
 
     static public @NotNull List<String> getRequiredCredMethods(@NotNull Tinode tinode, @NotNull String forAuthLevel) {

app/src/main/java/co/tinode/tindroid/format/FullFormatter.java

@@ -33,7 +33,6 @@
 import android.util.DisplayMetrics;
 import android.util.Log;
 import android.util.TypedValue;
-import android.view.Gravity;
 import android.view.View;
 import android.widget.TextView;
 
@@ -230,7 +229,9 @@ protected SpannableStringBuilder handleAudio(final Context ctx, List<SpannableSt
         Object val = data.get("preview");
         byte[] preview = null;
         if (val instanceof String) {
-            preview = Base64.decode((String) val, Base64.DEFAULT);
+            try {
+                preview = Base64.decode((String) val, Base64.DEFAULT);
+            } catch (IllegalArgumentException ignored) {}
         }
 
         if (preview != null && preview.length > MIN_AUDIO_PREVIEW_LENGTH) {
@@ -390,9 +391,10 @@ private CharacterStyle createImageSpan(final Context ctx, final Object val, fina
                 boolean usePreviewAsMainImage = false;
                 // If the message is not yet sent, the bits could be raw byte[] as opposed to
                 // base64-encoded.
-                byte[] bits = (val instanceof String) ?
-                        Base64.decode((String) val, Base64.DEFAULT) : (byte[]) val;
-                bmpPreview = BitmapFactory.decodeByteArray(bits, 0, bits.length);
+                byte[] bits = UiUtils.decodeByteArray(val);
+                if (bits != null) {
+                    bmpPreview = BitmapFactory.decodeByteArray(bits, 0, bits.length);
+                }
                 if (bmpPreview != null) {
                     // Check if the inline bitmap is big enough to be used as primary image.
                     int previewWidth = bmpPreview.getWidth();
@@ -658,9 +660,7 @@ protected SpannableStringBuilder handleAttachment(final Context ctx, final Map<S
 
         int byteCount = getIntVal("size", data);
         if (byteCount <= 0) {
-            Object val = data.get("val");
-            byte[] bits = (val instanceof String) ?
-                    Base64.decode((String) val, Base64.DEFAULT) : (byte[]) val;
+            byte[] bits = UiUtils.decodeByteArray(data.get("val"));
             if (bits != null) {
                 byteCount = bits.length;
             }

app/src/main/java/co/tinode/tindroid/format/QuoteFormatter.java

@@ -92,9 +92,11 @@ private CharacterStyle createImageSpan(Context ctx, Object val, String ref,
             try {
                 // If the message is not yet sent, the bits could be raw byte[] as opposed to
                 // base64-encoded.
-                byte[] bits = (val instanceof String) ?
-                        Base64.decode((String) val, Base64.DEFAULT) : (byte[]) val;
-                Bitmap bmp = BitmapFactory.decodeByteArray(bits, 0, bits.length);
+                byte[] bits = UiUtils.decodeByteArray(val);
+                Bitmap bmp = null;
+                if (bits != null) {
+                    bmp = BitmapFactory.decodeByteArray(bits, 0, bits.length);
+                }
                 if (bmp != null) {
                     if (dim.square) {
                         thumbnail = new BitmapDrawable(res,