Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizing the is_scalar_field function check logic #2307

Closed
wants to merge 1 commit into from

Conversation

aniaan
Copy link

@aniaan aniaan commented Nov 6, 2020

When I read this code of the is_scalar_field function, the logic here is a little difficult to read, here take not + not, I think here can reorganize the code to make it more clear and understandable

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2307 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f7447...187ee30. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

@aniaan aniaan closed this Nov 6, 2020
@aniaan aniaan reopened this Nov 6, 2020
@aniaan aniaan closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants