Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thoughtbot/clearance
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.0
Choose a base ref
...
head repository: thoughtbot/clearance
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.1
Choose a head ref
  • 9 commits
  • 19 files changed
  • 3 contributors

Commits on Jan 30, 2015

  1. Add documentation for configuration options

    Added Yard configuration and documentation for
    `Clearance::Configuration`. Moving forward, we will be adding
    documentation to the rest of Clearance.
    derekprior committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    de10fd6 View commit details
    Browse the repository at this point in the history
  2. README Refresh

    I took a pass through the README file and edited for brevity,
    organization, and correctness. I eliminated the various lists of
    overrideable methods as these were out of date and not particularly
    helpful in themselves. We already point the users to the overridable
    classes. Over time I'd like to move the overriding and extending
    documentation into the yarddoc itself or into a website that has recipes
    for various behaviors people often request. For now, I've slimmed some
    of it down but left most of it.
    
    I also removed reference to the `deny_access` matcher as it will soon be
    removed (to another gem) and I don't suggest its use.
    derekprior committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    c983fe2 View commit details
    Browse the repository at this point in the history
  3. Enable forgery protection on sessions#create

    This line has existed since 2008, and yet I can determine no
    justification for it. It seems to me that we *would* want CSRF
    protection on `session#create`.
    
    On its own, skipping CSRF protection in just this single action doesn't
    seem particularly useful to an attacker. Additional vectors (such as an
    overly-permissive CORS header) would have to be present to make use of
    this, but at that point far more interesting attacks would be possible
    on any cookie-based auth system.
    derekprior committed Jan 30, 2015
    Configuration menu
    Copy the full SHA
    7f5d56e View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2015

  1. Improve formatting of NEWS file

    * Follow olivierlacan/keep-a-changelog format.
    * Each release is linkable via header.
    * Each change is categorized.
    * Provide links to GitHub compares for each release.
    * Corrected some spelling.
    * Removed changes that were dev-only.
    derekprior committed Jan 31, 2015
    Configuration menu
    Copy the full SHA
    aefdc07 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2015

  1. Update rspec-rails version

    As a result:
    * In the ActionMailer initializer for the test app, we have to refer to the
    ActionMailer object itself to configure it instead of the app config. This was
    recommended in rspec/rspec-rails#1313.
    * We had to change the setup for rack_session_spec because RSpec now checks for
    mutation of arguments passed into spies.
    mxie committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    d762370 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2015

  1. Update README to reflect changes in RSpec 3

    Adding `clearance/rspec` to `spec/spec_helper.rb` in RSpec versions
    greater or equal to 3 will throw an `uninitialized constant
    Module::ActiveSupport` error, since the Rails env is not available.
    
    This updates the README in order to indicate the require statement
    should be placed in `spec/rails_helper.rb`.
    pedrosmmoreira authored and derekprior committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    8141301 View commit details
    Browse the repository at this point in the history
  2. Update to latest shoulda-matchers

    Change references to deprecated `set_the_flash` matcher.
    derekprior committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    21171c5 View commit details
    Browse the repository at this point in the history
  3. Don't expose authentication methods as actions

    There were a couple of methods from the Clearance::Authentication that
    were leaking through to become routable action methods on the
    controller. We need to hide them as actions.
    derekprior committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    f518f65 View commit details
    Browse the repository at this point in the history
  4. v1.8.1

    derekprior committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    e14ad62 View commit details
    Browse the repository at this point in the history
Loading