-
-
Notifications
You must be signed in to change notification settings - Fork 466
Comparing changes
Open a pull request
base repository: thoughtbot/clearance
base: v1.8.0
head repository: thoughtbot/clearance
compare: v1.8.1
- 9 commits
- 19 files changed
- 3 contributors
Commits on Jan 30, 2015
-
Add documentation for configuration options
Added Yard configuration and documentation for `Clearance::Configuration`. Moving forward, we will be adding documentation to the rest of Clearance.
Configuration menu - View commit details
-
Copy full SHA for de10fd6 - Browse repository at this point
Copy the full SHA de10fd6View commit details -
I took a pass through the README file and edited for brevity, organization, and correctness. I eliminated the various lists of overrideable methods as these were out of date and not particularly helpful in themselves. We already point the users to the overridable classes. Over time I'd like to move the overriding and extending documentation into the yarddoc itself or into a website that has recipes for various behaviors people often request. For now, I've slimmed some of it down but left most of it. I also removed reference to the `deny_access` matcher as it will soon be removed (to another gem) and I don't suggest its use.
Configuration menu - View commit details
-
Copy full SHA for c983fe2 - Browse repository at this point
Copy the full SHA c983fe2View commit details -
Enable forgery protection on sessions#create
This line has existed since 2008, and yet I can determine no justification for it. It seems to me that we *would* want CSRF protection on `session#create`. On its own, skipping CSRF protection in just this single action doesn't seem particularly useful to an attacker. Additional vectors (such as an overly-permissive CORS header) would have to be present to make use of this, but at that point far more interesting attacks would be possible on any cookie-based auth system.
Configuration menu - View commit details
-
Copy full SHA for 7f5d56e - Browse repository at this point
Copy the full SHA 7f5d56eView commit details
Commits on Jan 31, 2015
-
Improve formatting of NEWS file
* Follow olivierlacan/keep-a-changelog format. * Each release is linkable via header. * Each change is categorized. * Provide links to GitHub compares for each release. * Corrected some spelling. * Removed changes that were dev-only.
Configuration menu - View commit details
-
Copy full SHA for aefdc07 - Browse repository at this point
Copy the full SHA aefdc07View commit details
Commits on Mar 2, 2015
-
As a result: * In the ActionMailer initializer for the test app, we have to refer to the ActionMailer object itself to configure it instead of the app config. This was recommended in rspec/rspec-rails#1313. * We had to change the setup for rack_session_spec because RSpec now checks for mutation of arguments passed into spies.
Configuration menu - View commit details
-
Copy full SHA for d762370 - Browse repository at this point
Copy the full SHA d762370View commit details
Commits on Mar 3, 2015
-
Update README to reflect changes in RSpec 3
Adding `clearance/rspec` to `spec/spec_helper.rb` in RSpec versions greater or equal to 3 will throw an `uninitialized constant Module::ActiveSupport` error, since the Rails env is not available. This updates the README in order to indicate the require statement should be placed in `spec/rails_helper.rb`.
Configuration menu - View commit details
-
Copy full SHA for 8141301 - Browse repository at this point
Copy the full SHA 8141301View commit details -
Update to latest shoulda-matchers
Change references to deprecated `set_the_flash` matcher.
Configuration menu - View commit details
-
Copy full SHA for 21171c5 - Browse repository at this point
Copy the full SHA 21171c5View commit details -
Don't expose authentication methods as actions
There were a couple of methods from the Clearance::Authentication that were leaking through to become routable action methods on the controller. We need to hide them as actions.
Configuration menu - View commit details
-
Copy full SHA for f518f65 - Browse repository at this point
Copy the full SHA f518f65View commit details -
Configuration menu - View commit details
-
Copy full SHA for e14ad62 - Browse repository at this point
Copy the full SHA e14ad62View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.8.0...v1.8.1