Support client capabilities (ocaml.next-hole)
#54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
reviewed
Apr 15, 2025
5a47175 to
1125507
Compare
c4c98e0 to
67654b1
Compare
1029262 to
e58ae4a
Compare
e58ae4a to
1e9976a
Compare
voodoos
approved these changes
Apr 15, 2025
ocaml-eglot.el
Outdated
Comment on lines
712
to
726
| (when (fboundp 'eglot-execute) | ||
| (cl-defmethod eglot-execute :around (_ action) | ||
| "Custom handler for performing client commands." | ||
| (pcase (cl-getf action :command) | ||
| ("ocaml.next-hole" (ocaml-eglot--command-next-hole | ||
| (cl-getf action :arguments))) | ||
| (_ (cl-call-next-method))))) | ||
|
|
||
| (when (fboundp 'eglot-execute-command) | ||
| (cl-defmethod eglot-execute-command :around (_ command arguments) | ||
| "Custom handler for performing client commands (legacy)." | ||
| (pcase command | ||
| ("ocaml.next-hole" (ocaml-eglot--command-next-hole arguments)) | ||
| (_ (cl-call-next-method))))) | ||
|
|
There was a problem hiding this comment.
It might be useful for later or other dev to comment here on the reason why you need both of these.
In general these extensions looks quite tricky, documenting your implementation choices and the difficulty you encountered would be very valuable.
voodoos
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.