Skip to content

ocaml-eglot-alternate-file: find file alternate in other window #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

arvidj
Copy link

@arvidj arvidj commented Apr 7, 2025

Like the classic ff-find-other-file used by tuareg, open the alternate file in another window if the prefix argument is set. Also fix a spelling error.

@xvw
Copy link
Member

xvw commented Apr 9, 2025

WDYT about using the prefix argument. If the prefix is set, it open it into a new window, otherwise, it open it into the current one?

@arvidj
Copy link
Author

arvidj commented Apr 9, 2025

WDYT about using the prefix argument. If the prefix is set, it open it into a new window, otherwise, it open it into the current one?

Ah, sorry, the PR description is not very clear. In fact, what you describe is exactly what is implemented :)

@xvw
Copy link
Member

xvw commented Apr 9, 2025

Perfect! Can you add a change entry? Thanks a lot!

@arvidj arvidj force-pushed the aj/find-file-alternate-in-other-window branch from 535372b to 37120cb Compare April 10, 2025 07:52
@arvidj
Copy link
Author

arvidj commented Apr 10, 2025

Perfect! Can you add a change entry? Thanks a lot!

Done in latest.

Copy link
Member

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@xvw xvw merged commit 6d90b16 into tarides:main Apr 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants