Emacs 30 1 stewarding #37
Conversation
b1ec68a to
1e5ebd2
Compare
1e5ebd2 to
0e55188
Compare
| configuration in this way: | ||
|
|
||
| ```diff | ||
| (use-package ocaml-eglot |
There was a problem hiding this comment.
I"m guessing you can also add a use-package invocation for flycheck-eglot, so this example would be more complete.
| + :config | ||
| + (add-hook #'ocaml-eglot-hook |
There was a problem hiding this comment.
That's slightly different from your example above. (in the auto-format section) Perhaps you want to make them consistent?
There was a problem hiding this comment.
I think you're looking at the source and not the modification. In the diff, I relay to :hook ... Does this work for you?
There was a problem hiding this comment.
Ah, I didn't see this was a "diff". My bad!
Btw, I saw this block using "Scheme" as the language, but GH actually supports elisp and emacs-lisp for fenced code blocks:
(use-package ocaml-eglot
:ensure t
:after tuareg
:hook
(tuareg-mode . ocaml-eglot)
(ocaml-eglot . eglot-ensure))| @@ -294,14 +302,14 @@ If there is no available holes, it returns the first one of HOLES." | |||
|
|
|||
| (defun ocaml-eglot--first-hole-in (start end) | |||
| "Jump to the first hole in a given range denoted by START and END." | |||
| (when-let ((hole (ocaml-eglot--get-first-hole-in start end)) | |||
| (when-let* ((hole (ocaml-eglot--get-first-hole-in start end)) | |||
There was a problem hiding this comment.
The line below is not properly indented.
There was a problem hiding this comment.
I run indent-buffer on 7f8ab06
|
Thanks a lot for your review @bbatsov! |
74f0699 to
69fd31b
Compare
Some fixes after 30.1 (fix #31)