[DoctrineBridge] fix: DoctrineTokenProvider not oracle compatible #58523
Conversation
Oracle converts all not quoted names to uppercase
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -55,15 +55,17 @@ public function __construct(Connection $conn) | |||
| */ | |||
| public function loadTokenBySeries(string $series) | |||
| { | |||
| // the alias for lastUsed works around case insensitivity in PostgreSQL | |||
There was a problem hiding this comment.
This was introduced by #27314. The proposed patch also seems to handle postgres issue too.
|
Thank you @jjjb03. |
…h postgres connection (GromNaN) This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Add integration test for RememberMe with postgres connection | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Related to - #27314 - #58523 Commits ------- ca417c0 Add integration test for RememberMe with pg connection
Problem:
Oracle DB returns all not quoted names in uppercase
(vs. SQLite for example returns non quoted column names as lowercase)
On systems with oracle DB this leads to the Warning/Exception attached below.
see also: PHP Documentation - function.oci-fetch-array- Return Values