[FrameworkBundle] Add --no-fill option to translation:extract command
#58506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, please add tests for your new feature 🙏 |
--no-fill option to translation:extract command
6878c2f to
4068914
Compare
|
I have written some tests for |
OskarStark
reviewed
Oct 13, 2024
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Oct 13, 2024
src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Oct 23, 2024
| @@ -271,6 +271,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $operationResult = $this->sortCatalogue($operationResult, $sort); | |||
| } | |||
|
|
|||
| if (true === $input->getOption('no-fill')) { | |||
There was a problem hiding this comment.
Suggested change
| if (true === $input->getOption('no-fill')) { | |
| if ($input->getOption('no-fill')) { |
welcoMattic
approved these changes
Oct 23, 2024
e7bab82 to
c05aac3
Compare
|
Thank you @jawira. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--no-filloption totranslation:extractcommand.With this option, only translation keys are generated in the output file, while the translation values are left blank.
Example:
bin/console translation:extract --force --no-fill frWhen
--no-fillis used the--prefixoption has no effect.