Skip to content

[Notifier][GatewayAPI] Add support for label parameter #58427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

[Notifier][GatewayAPI] Add support for label parameter #58427

merged 1 commit into from
Oct 3, 2024

Conversation

nicodemuz
Copy link
Contributor

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Add label parameter for GatewayAPI.

From the documentation:

label (string) - A label added to each sent message, which can be used to uniquely identify a customer or company that you have sent the message on behalf of. Can e.g. be used when invoicing your customers. If specified it must be the same for all messages in the request.

@nicodemuz nicodemuz requested a review from OskarStark as a code owner October 1, 2024 07:45
@carsonbot carsonbot added this to the 7.2 milestone Oct 1, 2024
nicolas-grekas
nicolas-grekas reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you please add a note in the CHANGELOG file of the bridge?

OskarStark
OskarStark approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Nicolas' comment

@nicolas-grekas
Copy link
Member

Thank you @nicodemuz.

@nicolas-grekas nicolas-grekas merged commit baa08d6 into symfony:7.2 Oct 3, 2024
1 check was pending
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 3, 2024
Closed
@OskarStark OskarStark changed the title [Notifier] [GatewayAPI] Add support for label parameter [Notifier][GatewayAPI] Add support for label parameter Oct 3, 2024
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@nicodemuz @nicolas-grekas @OskarStark @carsonbot