Skip to content

[Notifier] deprecate the TransportFactoryTestCase #58335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

[Notifier] deprecate the TransportFactoryTestCase #58335

merged 1 commit into from
Sep 27, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 20, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? yes
Issues Fix #54100
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Sep 20, 2024
@carsonbot carsonbot changed the title [Notifier] deprecate not implementing data provider methods [Notifier] deprecate not implementing data provider methods Sep 20, 2024
@xabbuh xabbuh mentioned this pull request Sep 20, 2024
Closed
@derrabus
Copy link
Member

Does this really solve this problem? Implementers must not implement those methods by returning an empty array either. And if not providing any test cases is legitimate, what should the implementer do with those methods?

@xabbuh xabbuh force-pushed the issue-54100 branch 4 times, most recently from 37f1a90 to 5ea73f9 Compare September 20, 2024 12:22
@OskarStark
Copy link
Contributor

And if not providing any test cases is legitimate, what should the implementer do with those methods?

I agree, back in time I raised this question to Sebastian, but with no luck. It makes things way more complicated than they have to be 🤷

@xabbuh
Copy link
Member Author

xabbuh commented Sep 20, 2024

The new AbstractTransportFactoryTestCase defines just three tests (testSupports(), testCreate(), and testUnsupportedSchemeException()) for all which reasonable test data can be drafted for a transport factory.

There were two tests (testIncompleteDsnException() and MissingRequiredOptionTestTrait) that do not make sense for all transport factories. Those have been moved into traits.

@xabbuh xabbuh force-pushed the issue-54100 branch 5 times, most recently from 18f0c8a to a314c4f Compare September 23, 2024 06:39
This was referenced Sep 23, 2024
Merged
Merged
stof
stof approved these changes Sep 23, 2024
View reviewed changes
@xabbuh xabbuh changed the title [Notifier] deprecate not implementing data provider methods [Notifier] deprecate the TransportFactoryTestCase Sep 23, 2024
@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit abd7822 into symfony:7.2 Sep 27, 2024
7 of 10 checks passed
@fabpot fabpot mentioned this pull request Sep 27, 2024
Closed
@xabbuh xabbuh deleted the issue-54100 branch September 27, 2024 08:55
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Deprecation Notifier Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[Notifier] TransportFactoryTestCase incompatible with PHPUnit 11
6 participants
@xabbuh @derrabus @OskarStark @fabpot @stof @carsonbot