Skip to content

[Serializer] Deprecate AdvancedNameConverterInterface #58308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Sep 18, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? yes
Issues
License MIT

Deprecate the AdvancedNameConverterInterface in favor of NameConverterInterface as they'll have the same signature in 8.0

@chalasr
Copy link
Member

chalasr commented Sep 21, 2024

That interface looks indeed useless since 7.1. @xabbuh can you have a look as you were the one making NameConverterInterface methods' signatures the same as the AdvancedNameConverterInterface in 7.1?
If this is what we want, we probably need to add @param phpdoc annotations to each method of NameConverterInterface for the new params, to leverage DebugClassLoader's deprecation system.

@xabbuh
Copy link
Member

xabbuh commented Sep 24, 2024

👍 looks good to me

@mtarld mtarld force-pushed the feat/deprecate-advanced-name-converter-interface branch from e5ec432 to ac0f41f Compare September 24, 2024 08:21
@mtarld
Copy link
Contributor Author

mtarld commented Sep 24, 2024

@chalasr, the @param annotations are already on top of NameConverterInterface related methods.

@chalasr
Copy link
Member

chalasr commented Sep 24, 2024

Can you please rebase now that #58368 is merged to ensure tests keep passing despite an implementation exists in core?

@mtarld mtarld force-pushed the feat/deprecate-advanced-name-converter-interface branch from ac0f41f to 0a263d0 Compare September 25, 2024 07:20
@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

Thank you @mtarld.

@fabpot fabpot merged commit 9bc8007 into symfony:7.2 Sep 27, 2024
10 checks passed
@mtarld mtarld deleted the feat/deprecate-advanced-name-converter-interface branch September 27, 2024 08:42
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants