Skip to content

[Console][Process] Add $verbosity argument to mustRun helper method #58074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

willrowe
Copy link
Contributor

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT

This adds a 'verbosity' argument to 'mustRun' in order to match 'run'. There are no existing tests for 'mustRun', just 'run'.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.2 milestone Aug 23, 2024
@carsonbot carsonbot changed the title [Console] [Process] Add 'verbosity' argument to 'mustRun' helper method [Console][Process] Add 'verbosity' argument to 'mustRun' helper method Aug 23, 2024
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a changelog entry in the component.

@willrowe
Copy link
Contributor Author

@nicolas-grekas done.

@OskarStark OskarStark changed the title [Console][Process] Add 'verbosity' argument to 'mustRun' helper method [Console][Process] Add $verbosity argument to mustRun method Aug 30, 2024
@OskarStark OskarStark changed the title [Console][Process] Add $verbosity argument to mustRun method [Console][Process] Add $verbosity argument to mustRun helper method Aug 30, 2024
@nicolas-grekas
Copy link
Member

Thank you @willrowe.

@nicolas-grekas nicolas-grekas merged commit 5b35328 into symfony:7.2 Aug 30, 2024
4 of 6 checks passed
@willrowe willrowe deleted the patch-1 branch September 3, 2024 15:03
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants