[Webhook] decouple the Webhook component from the Serializer component #57881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 30, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #57567 |
| License | MIT |
derrabus
reviewed
Jul 30, 2024
derrabus
reviewed
Jul 30, 2024
derrabus
reviewed
Jul 30, 2024
yceruto
reviewed
Jul 30, 2024
yceruto
reviewed
Jul 30, 2024
nicolas-grekas
approved these changes
Aug 7, 2024
yceruto
approved these changes
Aug 7, 2024
fabpot
approved these changes
Aug 7, 2024
|
@fabpot I didn't want to confuse readers of the code by using the term serializer for two different things (the Serializer component and the part that I named encoder here). But I am open for other names. |
|
Serialization and encoding are two different concepts. Having |
|
@fabpot I renamed the new classes |
stof
approved these changes
Aug 13, 2024
OskarStark
approved these changes
Aug 14, 2024
fabpot
approved these changes
Aug 14, 2024
|
Thank you @xabbuh. |
chalasr
approved these changes
Aug 14, 2024
| @@ -548,7 +548,7 @@ public function load(array $configs, ContainerBuilder $container): void | |||
| $this->registerProfilerConfiguration($config['profiler'], $container, $loader); | |||
|
|
|||
| if ($this->readConfigEnabled('webhook', $container, $config['webhook'])) { | |||
| $this->registerWebhookConfiguration($config['webhook'], $container, $loader); | |||
| $this->registerWebhookConfiguration($config['webhook'], $container, $loader, $this->readConfigEnabled('serializer', $container, $config['serializer'])); | |||
|
|
|||
| // If Webhook is installed but the HttpClient or Serializer components are not available, we should throw an error | |||
There was a problem hiding this comment.
fabpot
added a commit
that referenced
this pull request
Aug 17, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [FrameworkBundle][Webhook] Fix comment | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #57881 (comment) | License | MIT Follows * #57881 Commits ------- b3bd0c6 [FrameworkBundle] Fix comment
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.