Skip to content

Unify how --format is handled by commands #57518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Jun 25, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? yes
Issues n/a
License MIT

We have many commands that have a --format option. This PR tries to unify the way we handle them:

  • Deprecate the text format (used only twice) in favor of the more common txt one;
  • Add auto-completion for --format in all commands;
  • Add help about the --format option in all commands that supports it (in a unified way)

Side note: To avoid confusion, I think we should rename the --format option for the uuid:generate and ulid:generate commands as it does something different from the commonly used --format option.

@OskarStark OskarStark changed the title Unify how --format is handle by commands Unify how --format is handled by commands Jun 25, 2024
@fabpot fabpot force-pushed the commands-with-formats branch 2 times, most recently from 5be5646 to 24f2958 Compare June 25, 2024 19:50
@fabpot fabpot force-pushed the commands-with-formats branch from 24f2958 to 848f855 Compare June 26, 2024 06:46
@fabpot fabpot merged commit f35780f into symfony:7.2 Jun 26, 2024
3 of 10 checks passed
@fabpot fabpot deleted the commands-with-formats branch June 26, 2024 06:51
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants