Separate tests not requiring internet access. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests in the existing test suite do not require internet access. However a few of them do make requests to external hosts -- this causes the test suite to fail when the user's network connection is down or otherwise unavailable. This commit separates the existing "spec" test suite into "spec" and "spec-nonet" components, the latter being the subset of tests that work when the network connection is down. A separate "test-nonet" directory is added to preserve the existing hspec autodiscovery magic. Some redundant imports were removed after the restructuring, and a few occurrences of unused variables were changed to "_".
|
Thanks, released to Hackage as 0.4.6.1. |
|
Awesome, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests in the existing test suite do not require internet
access. However a few of them do make requests to external hosts --
this causes the test suite to fail when the user's network connection
is down or otherwise unavailable.
This commit separates the existing "spec" test suite into "spec" and
"spec-nonet" components, the latter being the subset of tests that
work when the network connection is down. A separate "test-nonet"
directory is added to preserve the existing hspec autodiscovery magic.
Some redundant imports were removed after the restructuring, and a few
occurrences of unused variables were changed to "_".