Incorrect bounds on http-client-tls

[tfausak]

I think the bounds that http-client-tls has for http-client are wrong. http-client version 0.7.11 added the strippedHostName function. http-client-tls version uses that (for example here) but claims to work with any http-client >= 0.5. This causes build errors like this:

[1 of 1] Compiling Network.HTTP.Client.TLS ( Network/HTTP/Client/TLS.hs, dist/build/Network/HTTP/Client/TLS.o, dist/build/Network/HTTP/Client/TLS.dyn_o )

Network/HTTP/Client/TLS.hs:124:39: error:
    Variable not in scope:
      strippedHostName
        :: String -> connection-0.3.1:Network.Connection.Types.HostName
    |
124 |             { NC.connectionHostname = strippedHostName host
    |                                       ^^^^^^^^^^^^^^^^

Network/HTTP/Client/TLS.hs:141:39: error:
    Variable not in scope:
      strippedHostName
        :: String -> connection-0.3.1:Network.Connection.Types.HostName
    |
141 |             { NC.connectionHostname = strippedHostName serverName
    |                                       ^^^^^^^^^^^^^^^^

Network/HTTP/Client/TLS.hs:147:54: error:
    Variable not in scope:
      strippedHostName
        :: String -> connection-0.3.1:Network.Connection.Types.HostName
    |
147 |                     Nothing -> Just $ NC.OtherProxy (strippedHostName host) $ fromIntegral port
    |                                                      ^^^^^^^^^^^^^^^^

Fortunately a workaround is simple: use http-client-tls < 0.3.6.

[tfausak]

I think this was introduced by #477.

[snoyberg]

CC @robx

[robx]

Yeah, http-client-tls version 0.3.6 should have a lower bound on http-client of 0.7.11.

[snoyberg]

I’ll accept a PR to fix this, but I’m not going to spend time on Hackage revisions. If someone else wants to I’ll grant maintainer rights.

[ysangkok]

@snoyberg Thank you a lot for the merge. I can do a revision if you'd grant maintainer rights to my user. If you'd rather not, would it be possible to make the release of 0.3.6.1? Then this package would be buildable in the next nightly. It's not buildable in the current nightly.

[snoyberg]

I've uploaded the new http-client-tls and given you maintainer access on Hackage to the four packages in this repo.

[juhp]

I ran into this today, so it would still be good to revise http-client-tls-0.3.6, @ysangkok

[ysangkok]

Thank you snoyberg for the maintainer bit and for the release. Juhp, I have made a new revision for http-client-openssl 0.3.3 and for http-client-tls 0.3.6. Hopefully it will fix your issue, let me know if there are any more problems. Cheers!