Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunJS #716

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add RunJS #716

merged 2 commits into from
Jun 21, 2022

Conversation

lukehaas
Copy link
Contributor

By submitting this pull request, I promise I have read the contributing guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖

@lukehaas
Copy link
Contributor Author

Thanks @sindresorhus I read the guidelines.
Regarding the evidence of Electron, apologies, I thought this would be clear from the website link.
Further proof of this can be. seen in the docs of the app: https://runjs.app/docs.

@sindresorhus
Copy link
Owner

Further proof of this can be. seen in the docs of the app: https://runjs.app/docs.

There's no mention of Electron there.

@lukehaas
Copy link
Contributor Author

I see, but the guidelines only ask for evidence of Electron, wasn't sure how extensive this needs to be.
The RunJS docs state the Node, Chromium and V8 versions that it runs against, which match the Electon versions.

Further evidence is the entry in the official Electron app list: https://www.electronjs.org/apps/runjs

@sindresorhus
Copy link
Owner

The RunJS docs state the Node, Chromium and V8 versions that it runs against, which match the Electon versions.

That is an assumption, not evidence.

Further evidence is the entry in the official Electron app list: https://www.electronjs.org/apps/runjs

That is good enough for me.

@sindresorhus sindresorhus merged commit 59856d5 into sindresorhus:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants