Skip to content

Commit fea3ddd

Browse files
authored
[java] Close http connection for RemoteNode (#13313)
1 parent 060288e commit fea3ddd

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,12 @@ public void remove(NodeId nodeId) {
459459
Lock writeLock = lock.writeLock();
460460
writeLock.lock();
461461
try {
462+
Node node = nodes.get(nodeId);
463+
464+
if (node instanceof RemoteNode) {
465+
((RemoteNode) node).close();
466+
}
467+
462468
nodes.remove(nodeId);
463469
model.remove(nodeId);
464470
allChecks.remove(nodeId);

java/src/org/openqa/selenium/grid/node/remote/RemoteNode.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030

3131
import com.google.common.collect.ImmutableMap;
3232
import com.google.common.collect.ImmutableSet;
33+
import java.io.Closeable;
3334
import java.io.IOException;
3435
import java.io.Reader;
3536
import java.io.UncheckedIOException;
@@ -67,7 +68,7 @@
6768
import org.openqa.selenium.remote.tracing.HttpTracing;
6869
import org.openqa.selenium.remote.tracing.Tracer;
6970

70-
public class RemoteNode extends Node {
71+
public class RemoteNode extends Node implements Closeable {
7172

7273
public static final Json JSON = new Json();
7374
private final HttpHandler client;
@@ -267,6 +268,11 @@ private Map<String, Object> toJson() {
267268
"capabilities", capabilities);
268269
}
269270

271+
@Override
272+
public void close() {
273+
((HttpClient) (this.client)).close();
274+
}
275+
270276
private class RemoteCheck implements HealthCheck {
271277
@Override
272278
public Result check() {

0 commit comments

Comments
 (0)