Skip to content

Commit ec523b2

Browse files
committed
[java] Small code improvement in ProxyWebsocketsIntoGrid
1 parent c0ddca6 commit ec523b2

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

java/src/org/openqa/selenium/grid/router/ProxyWebsocketsIntoGrid.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import java.util.logging.Logger;
2929
import org.openqa.selenium.NoSuchSessionException;
3030
import org.openqa.selenium.grid.sessionmap.SessionMap;
31+
import org.openqa.selenium.internal.Require;
3132
import org.openqa.selenium.remote.HttpSessionId;
3233
import org.openqa.selenium.remote.SessionId;
3334
import org.openqa.selenium.remote.http.BinaryMessage;
@@ -53,11 +54,12 @@ public ProxyWebsocketsIntoGrid(HttpClient.Factory clientFactory, SessionMap sess
5354

5455
@Override
5556
public Optional<Consumer<Message>> apply(String uri, Consumer<Message> downstream) {
56-
Objects.requireNonNull(uri);
57-
Objects.requireNonNull(downstream);
57+
Require.nonNull("uri", uri);
58+
Require.nonNull("downstream", downstream);
5859

5960
Optional<SessionId> sessionId = HttpSessionId.getSessionId(uri).map(SessionId::new);
60-
if (!sessionId.isPresent()) {
61+
if (sessionId.isEmpty()) {
62+
LOG.warning("Session not found for uri " + uri);
6163
return Optional.empty();
6264
}
6365

@@ -72,7 +74,7 @@ public Optional<Consumer<Message>> apply(String uri, Consumer<Message> downstrea
7274
return Optional.of(upstream::send);
7375

7476
} catch (NoSuchSessionException e) {
75-
LOG.info("Attempt to connect to non-existent session: " + uri);
77+
LOG.warning("Attempt to connect to non-existent session: " + uri);
7678
return Optional.empty();
7779
}
7880
}

0 commit comments

Comments
 (0)