Skip to content

Commit eba101d

Browse files
committed
[rb] update rubocop and revert incorrect changes
1 parent 7c1b450 commit eba101d

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

rb/Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ GEM
9898
diff-lcs (>= 1.2.0, < 2.0)
9999
rspec-support (~> 3.12.0)
100100
rspec-support (3.12.1)
101-
rubocop (1.60.1)
101+
rubocop (1.60.2)
102102
json (~> 2.3)
103103
language_server-protocol (>= 3.17.0)
104104
parallel (~> 1.10)
@@ -170,7 +170,7 @@ DEPENDENCIES
170170
rack (~> 2.0)
171171
rake (~> 13.0)
172172
rspec (~> 3.0)
173-
rubocop (~> 1.42)
173+
rubocop (~> 1.60, >= 1.60.2)
174174
rubocop-performance (~> 1.15)
175175
rubocop-rspec (~> 2.16)
176176
selenium-devtools!

rb/lib/selenium/webdriver/bidi/log_inspector.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,28 +50,28 @@ def initialize(driver, browsing_context_ids = nil)
5050
@bidi.session.subscribe('log.entryAdded', browsing_context_ids)
5151
end
5252

53-
def on_console_entry(...)
53+
def on_console_entry(filter_by = nil, &block)
5454
check_valid_filter(filter_by)
5555

5656
on_log do |params|
5757
type = params['type']
58-
console_log_events(params, ...) if type.eql?('console')
58+
console_log_events(params, filter_by, &block) if type.eql?('console')
5959
end
6060
end
6161

62-
def on_javascript_log(...)
62+
def on_javascript_log(filter_by = nil, &block)
6363
check_valid_filter(filter_by)
6464

6565
on_log do |params|
6666
type = params['type']
67-
javascript_log_events(params, ...) if type.eql?('javascript')
67+
javascript_log_events(params, filter_by, &block) if type.eql?('javascript')
6868
end
6969
end
7070

71-
def on_javascript_exception(...)
71+
def on_javascript_exception(&block)
7272
on_log do |params|
7373
type = params['type']
74-
javascript_log_events(params, FilterBy.log_level('error'), ...) if type.eql?('javascript')
74+
javascript_log_events(params, FilterBy.log_level('error'), &block) if type.eql?('javascript')
7575
end
7676
end
7777

rb/lib/selenium/webdriver/common/zipper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ def zip_file(path)
7171

7272
private
7373

74-
def with_tmp_zip(...)
74+
def with_tmp_zip(&blk)
7575
# Don't use Tempfile since it lacks rb_file_s_rename permission on Windows.
7676
Dir.mktmpdir do |tmp_dir|
7777
zip_path = File.join(tmp_dir, 'webdriver-zip')
78-
Zip::File.open(zip_path, Zip::File::CREATE, ...)
78+
Zip::File.open(zip_path, Zip::File::CREATE, &blk)
7979
end
8080
end
8181

rb/lib/selenium/webdriver/devtools/network_interceptor.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ def initialize(devtools)
4343
@lock = Mutex.new
4444
end
4545

46-
def intercept(...)
46+
def intercept(&block)
4747
devtools.network.on(:loading_failed) { |params| track_cancelled_request(params) }
48-
devtools.fetch.on(:request_paused) { |params| request_paused(params, ...) }
48+
devtools.fetch.on(:request_paused) { |params| request_paused(params, &block) }
4949

5050
devtools.network.set_cache_disabled(cache_disabled: true)
5151
devtools.network.enable

rb/selenium-webdriver.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Gem::Specification.new do |s|
5656
s.add_development_dependency 'rack', ['~> 2.0']
5757
s.add_development_dependency 'rake', ['~> 13.0']
5858
s.add_development_dependency 'rspec', ['~> 3.0']
59-
s.add_development_dependency 'rubocop', ['~> 1.42']
59+
s.add_development_dependency 'rubocop', ['~> 1.60', '>=1.60.2']
6060
s.add_development_dependency 'rubocop-performance', ['~> 1.15']
6161
s.add_development_dependency 'rubocop-rspec', ['~> 2.16']
6262
s.add_development_dependency 'webmock', ['~> 3.5']

0 commit comments

Comments
 (0)