Skip to content

Commit e7fb98b

Browse files
committed
[dotnet] update parameter name to allowedIpAddresses and make whitelistedIpAddresses obsolete
1 parent cea0a3c commit e7fb98b

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

dotnet/src/webdriver/Chromium/ChromiumDriverService.cs

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public abstract class ChromiumDriverService : DriverService
3333
private string logPath = string.Empty;
3434
private string urlPathPrefix = string.Empty;
3535
private string portServerAddress = string.Empty;
36-
private string whitelistedIpAddresses = string.Empty;
36+
private string allowedIpAddresses = string.Empty;
3737
private int adbPort = -1;
3838
private bool disableBuildCheck;
3939
private bool enableVerboseLogging;
@@ -123,10 +123,22 @@ public bool EnableAppendLog
123123
/// connect to this instance of the Chrome driver. Defaults to an empty string,
124124
/// which means only the local loopback address can connect.
125125
/// </summary>
126-
public string WhitelistedIPAddresses
126+
[Obsolete("Use AllowedIpAddresses")]
127+
public string WhitelistedIpAddresses
127128
{
128-
get { return this.whitelistedIpAddresses; }
129-
set { this.whitelistedIpAddresses = value; }
129+
get { return this.allowedIpAddresses; }
130+
set { this.allowedIpAddresses = value; }
131+
}
132+
133+
/// <summary>
134+
/// Gets or sets the comma-delimited list of IP addresses that are approved to
135+
/// connect to this instance of the Chrome driver. Defaults to an empty string,
136+
/// which means only the local loopback address can connect.
137+
/// </summary>
138+
public string AllowedIpAddresses
139+
{
140+
get { return this.allowedIpAddresses; }
141+
set { this.allowedIpAddresses = value; }
130142
}
131143

132144
/// <summary>
@@ -177,9 +189,9 @@ protected override string CommandLineArguments
177189
argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --port-server={0}", this.portServerAddress);
178190
}
179191

180-
if (!string.IsNullOrEmpty(this.whitelistedIpAddresses))
192+
if (!string.IsNullOrEmpty(this.allowedIpAddresses))
181193
{
182-
argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " -whitelisted-ips={0}", this.whitelistedIpAddresses));
194+
argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " -allowed-ips={0}", this.allowedIpAddresses));
183195
}
184196

185197
return argsBuilder.ToString();

0 commit comments

Comments
 (0)