Skip to content

Commit e34220c

Browse files
[py] clean up of usage of executable path in services
1 parent f26e6bd commit e34220c

File tree

6 files changed

+10
-16
lines changed

6 files changed

+10
-16
lines changed

py/selenium/webdriver/firefox/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def __init__(
4545
self.service_args = service_args or []
4646

4747
super().__init__(
48-
executable=executable_path,
48+
executable_path=executable_path,
4949
port=port,
5050
log_output=log_output,
5151
env=env,

py/selenium/webdriver/ie/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def __init__(
5252
self.service_args.append(f"--log-level={log_level}")
5353

5454
super().__init__(
55-
executable_path,
55+
executable_path=executable_path,
5656
port=port,
5757
log_output=log_output,
5858
**kwargs,

py/selenium/webdriver/safari/service.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,15 @@ def __init__(
4444
) -> None:
4545
self.service_args = service_args or []
4646
if quiet is not None:
47-
warnings.warn("quiet is no longer needed to supress output", DeprecationWarning, stacklevel=2)
47+
warnings.warn(
48+
"quiet is no longer needed to supress output",
49+
DeprecationWarning,
50+
stacklevel=2,
51+
)
4852

4953
self._reuse_service = reuse_service
5054
super().__init__(
51-
executable=executable_path,
55+
executable_path=executable_path,
5256
port=port,
5357
env=env,
5458
**kwargs,

py/selenium/webdriver/webkitgtk/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def __init__(
4444
self.service_args = service_args or []
4545
log_file = open(log_path, "wb") if log_path else None
4646
super().__init__(
47-
executable=executable_path,
47+
executable_path=executable_path,
4848
port=port,
4949
log_file=log_file,
5050
env=env,

py/selenium/webdriver/wpewebkit/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def __init__(
4444
self.service_args = service_args or []
4545
log_file = open(log_path, "wb") if log_path else None
4646
super().__init__(
47-
executable=executable_path,
47+
executable_path=executable_path,
4848
port=port,
4949
log_file=log_file,
5050
env=env,

py/test/selenium/webdriver/common/selenium_manager_tests.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,3 @@ def test_stderr_is_propagated_to_exception_messages():
101101
manager = SeleniumManager()
102102
binary = manager.get_binary()
103103
_ = manager.run([str(binary), "--browser", "foo"])
104-
105-
106-
def test_driver_finder_error(mocker):
107-
mocker.patch("selenium.webdriver.common.selenium_manager.SeleniumManager.driver_location", return_value=None)
108-
109-
service = Service()
110-
options = Options()
111-
msg = r"Unable to locate or obtain driver for chrome.*errors\/driver_location"
112-
with pytest.raises(WebDriverException, match=msg):
113-
DriverFinder.get_path(service, options)

0 commit comments

Comments
 (0)