Fixing issue #1479. The only reasonable thing we can do for select elements is to disable clickability checking, see https://gist.github.com/p0deje/c549e93fa19bf7aaee49

Author: barancev

common/src/web/selectPage.html

@@ -47,5 +47,12 @@
     <option>five</option>
     <option>six</option>
   </select>
+
+  <select id="narrow" style="width: 50px;">
+    <option value="evalon">LaClare Farms Evalon with Cummin</option>
+    <option value="savourine">Yarra Valley Vintage Savourine</option>
+    <option value="cheddar">Avonlea Clothbound Cheddar</option>
+  </select>
+
 </body>
 </html>

java/client/test/org/openqa/selenium/support/ui/SelectElementTest.java

@@ -26,6 +26,7 @@
 import org.junit.Before;
 import org.junit.Test;
 import org.openqa.selenium.By;
+import org.openqa.selenium.NoSuchElementException;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.testing.Ignore;
 import org.openqa.selenium.testing.JUnit4TestBase;
@@ -39,7 +40,7 @@ public void runBeforeEveryTest() {
     driver.get(pages.formPage);
   }
 
-  @Test(expected = org.openqa.selenium.support.ui.UnexpectedTagNameException.class)
+  @Test(expected = UnexpectedTagNameException.class)
   public void shouldThrowAnExceptionIfTheElementIsNotASelectElement() {
     WebElement selectElement = driver.findElement(By.name("checky"));
     Select select = new Select(selectElement);
@@ -141,7 +142,7 @@ public void shouldReturnFirstSelectedOption() {
     assertEquals("Eggs",firstSelected.getText());
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldThrowANoSuchElementExceptionIfNothingIsSelected() {
     WebElement selectElement = driver.findElement(By.name("select_empty_multiple"));
     Select select = new Select(selectElement);
@@ -158,14 +159,14 @@ public void shouldAllowOptionsToBeSelectedByVisibleText() {
     assertEquals("select_2",firstSelected.getText());
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldNotAllowInvisibleOptionsToBeSelectedByVisibleText() {
     WebElement selectElement = driver.findElement(By.name("invisi_select"));
     Select select = new Select(selectElement);
     select.selectByVisibleText("Apples");
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldThrowExceptionOnSelectByVisibleTextIfOptionDoesNotExist() {
     WebElement selectElement = driver.findElement(By.name("select_empty_multiple"));
     Select select = new Select(selectElement);
@@ -181,7 +182,7 @@ public void shouldAllowOptionsToBeSelectedByIndex() {
     assertEquals("select_2",firstSelected.getText());
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldThrowExceptionOnSelectByIndexIfOptionDoesNotExist() {
     WebElement selectElement = driver.findElement(By.name("select_empty_multiple"));
     Select select = new Select(selectElement);
@@ -197,7 +198,7 @@ public void shouldAllowOptionsToBeSelectedByReturnedValue() {
     assertEquals("select_2",firstSelected.getText());
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldThrowExceptionOnSelectByReturnedValueIfOptionDoesNotExist() {
     WebElement selectElement = driver.findElement(By.name("select_empty_multiple"));
     Select select = new Select(selectElement);
@@ -215,7 +216,7 @@ public void shouldAllowUserToDeselectAllWhenSelectSupportsMultipleSelections() {
     assertEquals(0,returnedOptions.size());
   }
 
-  @Test(expected = java.lang.UnsupportedOperationException.class)
+  @Test(expected = UnsupportedOperationException.class)
   public void shouldNotAllowUserToDeselectAllWhenSelectDoesNotSupportMultipleSelections() {
     WebElement selectElement = driver.findElement(By.name("selectomatic"));
     Select select = new Select(selectElement);
@@ -232,7 +233,7 @@ public void shouldAllowUserToDeselectOptionsByVisibleText() {
     assertEquals(1,returnedOptions.size());
   }
 
-  @Test(expected = org.openqa.selenium.NoSuchElementException.class)
+  @Test(expected = NoSuchElementException.class)
   public void shouldNotAllowUserToDeselectOptionsByInvisibleText() {
     WebElement selectElement = driver.findElement(By.name("invisi_select"));
     Select select = new Select(selectElement);
@@ -258,4 +259,15 @@ public void shouldAllowOptionsToBeDeselectedByReturnedValue() {
 
     assertEquals(1,returnedOptions.size());
   }
+
+  @Test
+  public void shouldAllowOptionsToBeSelectedFromTheSelectElementThatIsNarrowerThanOptions() {
+    driver.get(pages.selectPage);
+    WebElement selectElement = driver.findElement(By.id("narrow"));
+    Select select = new Select(selectElement);
+    select.selectByIndex(1);
+    List<WebElement> returnedOptions = select.getAllSelectedOptions();
+
+    assertEquals(1,returnedOptions.size());
+  }
 }

javascript/firefox-driver/js/syntheticMouse.js

@@ -108,6 +108,11 @@ SyntheticMouse.prototype.isElementClickable = function(element) {
 
   var tagName = element.tagName.toLowerCase();
 
+  // TODO: https://gist.github.com/p0deje/c549e93fa19bf7aaee49
+  if ('select' == tagName) {
+    return;
+  }
+
   // Check to see if this is an option element. If it is, and the parent isn't a multiple
   // select, then check that select is clickable.
   if ('option' == tagName) {
@@ -283,11 +288,12 @@ SyntheticMouse.prototype.click = function(target) {
     }
 
     if (parent && parent.tagName.toLowerCase() == 'select' && !parent.multiple) {
+      goog.log.info(SyntheticMouse.LOG_, 'About to do a bot.action.click on ' + element);
       bot.action.click(parent, undefined /* coords */);
     }
 
     goog.log.info(SyntheticMouse.LOG_, 'About to do a bot.action.click on ' + element);
-    bot.action.click(element, this.lastMousePosition, new bot.Mouse(null, this.modifierKeys));
+    bot.action.click(element, undefined, new bot.Mouse(null, this.modifierKeys));
 
   } else {
     goog.log.info(SyntheticMouse.LOG_, 'About to do a bot.action.click on ' + element);