Skip to content

Commit aeb0d62

Browse files
committed
[rust] Fix condition to download browser in discover local browser logic
1 parent 8cd85d5 commit aeb0d62

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

rust/src/lib.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,8 @@ pub trait SeleniumManager {
427427
}
428428

429429
fn discover_local_browser(&mut self) -> Result<(), Error> {
430-
if !self.is_force_browser_download() {
430+
let mut download_browser = self.is_force_browser_download();
431+
if !download_browser {
431432
let major_browser_version = self.get_major_browser_version();
432433
match self.discover_browser_version()? {
433434
Some(discovered_version) => {
@@ -463,7 +464,7 @@ pub trait SeleniumManager {
463464
self.get_browser_name(),
464465
discovered_major_browser_version,
465466
));
466-
self.set_download_browser(true);
467+
download_browser = true;
467468
}
468469
} else {
469470
self.set_browser_version(discovered_version);
@@ -478,7 +479,7 @@ pub trait SeleniumManager {
478479
discovered_major_browser_version,
479480
major_browser_version,
480481
));
481-
self.set_download_browser(true);
482+
download_browser = true;
482483
} else {
483484
self.set_browser_version(discovered_version);
484485
}
@@ -498,10 +499,11 @@ pub trait SeleniumManager {
498499
self.get_browser_name(),
499500
self.get_browser_version_label()
500501
));
501-
self.set_download_browser(true);
502+
download_browser = true;
502503
}
503504
}
504505
}
506+
self.set_download_browser(download_browser);
505507

506508
Ok(())
507509
}

0 commit comments

Comments
 (0)