Skip to content

Commit 64aea82

Browse files
committed
[py] remove deprecated reuse_service parameter from Safari driver constructor
1 parent da80617 commit 64aea82

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

py/selenium/webdriver/safari/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def __init__(
5050
stacklevel=2,
5151
)
5252

53-
self._reuse_service = reuse_service
53+
self.reuse_service = reuse_service
5454
super().__init__(
5555
executable_path=executable_path,
5656
port=port,

py/selenium/webdriver/safari/webdriver.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
# under the License.
1717

1818
import http.client as http_client
19-
import warnings
2019

2120
from selenium.common.exceptions import WebDriverException
2221
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
@@ -32,7 +31,6 @@ class WebDriver(RemoteWebDriver):
3231

3332
def __init__(
3433
self,
35-
reuse_service=False,
3634
keep_alive=True,
3735
options: Options = None,
3836
service: Service = None,
@@ -41,26 +39,17 @@ def __init__(
4139
safaridriver service.
4240
4341
:Args:
44-
- reuse_service - If True, do not spawn a safaridriver instance; instead, connect to an already-running service that was launched externally.
4542
- keep_alive - Whether to configure SafariRemoteConnection to use
4643
HTTP keep-alive. Defaults to True.
4744
- options - Instance of ``options.Options``.
4845
- service - Service object for handling the browser driver if you need to pass extra details
4946
"""
50-
if reuse_service:
51-
warnings.warn(
52-
"reuse_service has been deprecated, please use the Service class to set it",
53-
DeprecationWarning,
54-
stacklevel=2,
55-
)
56-
5747
self.service = service if service else Service()
5848
options = options if options else Options()
5949

6050
self.service.path = DriverFinder.get_path(self.service, options)
6151

62-
self._reuse_service = reuse_service and self.service.reuse_service
63-
if not self._reuse_service:
52+
if not self.service.reuse_service:
6453
self.service.start()
6554

6655
executor = SafariRemoteConnection(
@@ -81,7 +70,7 @@ def quit(self):
8170
except http_client.BadStatusLine:
8271
pass
8372
finally:
84-
if not self._reuse_service:
73+
if not self.service.reuse_service:
8574
self.service.stop()
8675

8776
# safaridriver extension commands. The canonical command support matrix is here:

0 commit comments

Comments
 (0)