Skip to content

Commit 5494e07

Browse files
committed
[py] update driver constructor typing
1 parent e91ba21 commit 5494e07

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

py/selenium/webdriver/chromium/webdriver.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ class ChromiumDriver(RemoteWebDriver):
2828

2929
def __init__(
3030
self,
31-
browser_name,
32-
vendor_prefix,
33-
options: ArgOptions,
34-
service: Service,
35-
keep_alive=True,
31+
browser_name: str = None,
32+
vendor_prefix: str = None,
33+
options: ArgOptions = ArgOptions(),
34+
service: Service = None,
35+
keep_alive: bool = True,
3636
) -> None:
3737
"""Creates a new WebDriver instance of the ChromiumDriver. Starts the
3838
service and then creates new WebDriver instance of ChromiumDriver.

py/selenium/webdriver/firefox/webdriver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def __init__(
4242
self,
4343
options: Options = None,
4444
service: Service = None,
45-
keep_alive=True,
45+
keep_alive: bool = True,
4646
) -> None:
4747
"""Creates a new instance of the Firefox driver. Starts the service and
4848
then creates new instance of Firefox driver.

py/selenium/webdriver/ie/webdriver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def __init__(
3131
self,
3232
options: Options = None,
3333
service: Service = None,
34-
keep_alive=True,
34+
keep_alive: bool = True,
3535
) -> None:
3636
"""Creates a new instance of the Ie driver.
3737
@@ -40,7 +40,7 @@ def __init__(
4040
:Args:
4141
- options - IE Options instance, providing additional IE options
4242
- service - (Optional) service instance for managing the starting and stopping of the driver.
43-
- keep_alive - Deprecated: Whether to configure RemoteConnection to use HTTP keep-alive.
43+
- keep_alive - Whether to configure RemoteConnection to use HTTP keep-alive.
4444
"""
4545

4646
self.service = service if service else Service()

0 commit comments

Comments
 (0)