Skip to content

Commit 4dc45f7

Browse files
committed
[dotnet] remove download url parameter from driver service constructor
nothing is done with this parameter and users passing in a value should get an error rather than having it be ignored
1 parent e7fb98b commit 4dc45f7

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

dotnet/src/webdriver/Chromium/ChromiumDriverService.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ public abstract class ChromiumDriverService : DriverService
4545
/// <param name="executablePath">The full path to the ChromeDriver executable.</param>
4646
/// <param name="executableFileName">The file name of the ChromeDriver executable.</param>
4747
/// <param name="port">The port on which the ChromeDriver executable should listen.</param>
48-
/// <param name="downloadUrl">The URL from which the driver executable can be downloaded.</param>
49-
protected ChromiumDriverService(string executablePath, string executableFileName, int port, Uri downloadUrl = null)
48+
protected ChromiumDriverService(string executablePath, string executableFileName, int port)
5049
: base(executablePath, port, executableFileName)
5150
{
5251
}

dotnet/src/webdriver/DriverService.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,13 @@ public abstract class DriverService : ICommandServer
5050
/// <param name="servicePath">The full path to the directory containing the executable providing the service to drive the browser.</param>
5151
/// <param name="port">The port on which the driver executable should listen.</param>
5252
/// <param name="driverServiceExecutableName">The file name of the driver service executable.</param>
53-
/// <param name="driverServiceDownloadUrl">This parameter is no longer used; kept for backwards compatibility.</param>
5453
/// <exception cref="ArgumentException">
5554
/// If the path specified is <see langword="null"/> or an empty string.
5655
/// </exception>
5756
/// <exception cref="DriverServiceNotFoundException">
5857
/// If the specified driver service executable does not exist in the specified directory.
5958
/// </exception>
60-
protected DriverService(string servicePath, int port, string driverServiceExecutableName, Uri driverServiceDownloadUrl = null)
59+
protected DriverService(string servicePath, int port, string driverServiceExecutableName)
6160
{
6261
this.driverServicePath = servicePath;
6362
this.driverServiceExecutableName = driverServiceExecutableName;

0 commit comments

Comments
 (0)