[py] use Selenium Manager in tests with bazel when pinned browsers not set

This can be overridden by specifying --driver-binary in addopts in pytest.ini

Author: titusfortner

py/conftest.py

@@ -98,8 +98,8 @@ def pytest_ignore_collect(path, config):
 def driver(request):
     kwargs = {}
 
-    # browser can be changed with `--driver=firefox` as an argument or in pytest.ini
-    driver_class = request.param.capitalize() if request.param else "Chrome"
+    # browser can be changed with `--driver=firefox` as an argument or to addopts in pytest.ini
+    driver_class = getattr(request, 'param', 'Chrome').capitalize()
 
     # skip tests if not available on the platform
     _platform = platform.system()

py/private/browsers.bzl

@@ -24,9 +24,6 @@ chrome_args = select({
         "--driver-binary=$(location @mac_chromedriver//:chromedriver)",
         "--browser-binary=$(location @mac_chrome//:Chrome.app)/Contents/MacOS/Chrome",
     ],
-    "@selenium//common:use_local_chromedriver": [
-        "--driver-binary=$(location @selenium//common:chromedriver)",
-    ],
     "//conditions:default": [],
 }) + headless_args
 
@@ -35,9 +32,6 @@ edge_args = select({
         "--driver-binary=$(location @mac_edgedriver//:msedgedriver)",
         "--browser-binary='$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft Edge'",
     ],
-    "@selenium//common:use_local_msedgedriver": [
-        "--driver-binary=$(location @selenium//common:msedgedriver)",
-    ],
     "//conditions:default": [],
 }) + headless_args
 
@@ -50,9 +44,6 @@ firefox_args = select({
         "--driver-binary=$(location @mac_geckodriver//:geckodriver)",
         "--browser-binary=$(location @mac_firefox//:Firefox.app)/Contents/MacOS/firefox",
     ],
-    "@selenium//common:use_local_geckodriver": [
-        "--driver-binary=$(location @selenium//common:geckodriver)",
-    ],
     "//conditions:default": [],
 }) + headless_args