Skip to content

Commit 2f1f779

Browse files
committed
[rb] explicitly check for whether driver supports full page screenshots to error (#12799)
1 parent 24d88d7 commit 2f1f779

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

rb/lib/selenium/webdriver/common/takes_screenshot.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ def save_screenshot(png_path, full_page: false)
4949
# @api public
5050

5151
def screenshot_as(format, full_page: false)
52+
if full_page && !respond_to(:full_page)
53+
raise Error::UnsupportedOperationError, "Full Page Screenshots are not supported for #{inspect}"
54+
end
55+
5256
case format
5357
when :base64
5458
full_page ? full_screenshot : screenshot
@@ -57,8 +61,6 @@ def screenshot_as(format, full_page: false)
5761
else
5862
raise Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
5963
end
60-
rescue NameError
61-
raise Error::UnsupportedOperationError, "Full Page Screenshots are not supported for #{inspect}"
6264
end
6365
end # TakesScreenshot
6466
end # WebDriver

0 commit comments

Comments
 (0)