[java] Refactoring to check for emptiness (#13335)

* Optimized checking for empty collections in ChromeDriverFunctionalTest

Replaced size-based checks for collection emptiness with isEmpty method calls in ChromeDriverFunctionalTest class. This change simplifies the code and potentially improves performance by avoiding unnecessary size calculations when just checking if the collection is empty or not.

* Replace size checks with isEmpty method

Replaced all the instances where the size of a collection was being checked to see if it was greater than zero, with the isEmpty method. The isEmpty method is more efficient and performant because it doesn't need to count all elements in order to determine if the collection has any elements, it just checks if there is at least one.

Author: manuelsblanco

java/src/org/openqa/selenium/By.java

@@ -446,7 +446,7 @@ protected final Map<String, Object> toJson() {
 
     private String cssEscape(String using) {
       using = CSS_ESCAPE.matcher(using).replaceAll("\\\\$1");
-      if (using.length() > 0 && Character.isDigit(using.charAt(0))) {
+      if (!using.isEmpty() && Character.isDigit(using.charAt(0))) {
         using = "\\" + (30 + Integer.parseInt(using.substring(0, 1))) + " " + using.substring(1);
       }
       return using;

java/src/org/openqa/selenium/devtools/CdpClientGenerator.java

@@ -269,12 +269,12 @@ public void dumpTo(Path target) {
       Path domainDir = target.resolve(name.toLowerCase());
       ensureDirectoryExists(domainDir);
       dumpMainClass(domainDir);
-      if (types.size() > 0) {
+      if (!types.isEmpty()) {
         Path typesDir = domainDir.resolve("model");
         ensureDirectoryExists(typesDir);
         types.forEach(type -> type.dumpTo(typesDir));
       }
-      if (events.size() > 0) {
+      if (!events.isEmpty()) {
         Path eventsDir = domainDir.resolve("model");
         ensureDirectoryExists(eventsDir);
         events.forEach(event -> event.dumpTo(eventsDir));
@@ -486,7 +486,7 @@ public EventParser() {
                               parameter.parse(item);
                               parameters.add(parameter);
                             });
-                    if (parameters.size() == 0) {
+                    if (parameters.isEmpty()) {
                       event.type = new VoidType();
                     } else if (parameters.size() == 1) {
                       event.type = parameters.get(0).type;
@@ -721,7 +721,7 @@ public CommandSpecParser() {
                               res.parse(item);
                               returns.add(res);
                             });
-                    if (returns.size() == 0) {
+                    if (returns.isEmpty()) {
                       command.type = new VoidType();
                     } else if (returns.size() == 1) {
                       command.type = returns.get(0).type;
@@ -1165,7 +1165,7 @@ public TypeDeclaration<?> toTypeDeclaration() {
       fromJson.setType(capitalize(name));
       fromJson.addParameter(JsonInput.class, "input");
       BlockStmt body = fromJson.getBody().get();
-      if (properties.size() > 0) {
+      if (!properties.isEmpty()) {
         properties.forEach(
             property -> {
               if (property.optional) {

java/src/org/openqa/selenium/docker/Device.java

@@ -34,7 +34,7 @@ private Device(String pathOnHost, String pathInContainer, String cgroupPermissio
   }
 
   public static Device device(String pathOnHost, String pathInContainer, String cgroupPermissions) {
-    if (Objects.isNull(cgroupPermissions) || cgroupPermissions.trim().length() == 0) {
+    if (Objects.isNull(cgroupPermissions) || cgroupPermissions.trim().isEmpty()) {
       cgroupPermissions = "crw";
     }
     return new Device(pathOnHost, pathInContainer, cgroupPermissions);

java/src/org/openqa/selenium/docker/v1_41/CreateContainer.java

@@ -71,7 +71,7 @@ public Container apply(ContainerConfig info) {
 
       if (rawContainer.get("Warnings") instanceof Collection) {
         Collection<?> warnings = (Collection<?>) rawContainer.get("Warnings");
-        if (warnings.size() > 0) {
+        if (!warnings.isEmpty()) {
           String allWarnings =
               warnings.stream().map(String::valueOf).collect(Collectors.joining("\n", " * ", ""));
 

java/src/org/openqa/selenium/grid/TemplateGridCommand.java

@@ -90,7 +90,7 @@ public final Executable configure(PrintStream out, PrintStream err, String... ar
               .filter(ParameterDescription::isAssigned)
               .map(ParameterDescription::getLongestName)
               .collect(Collectors.toSet());
-      if (cliArgs.size() > 0) {
+      if (!cliArgs.isEmpty()) {
         allFlags.forEach(flags -> allConfigs.add(new AnnotatedConfig(flags, cliArgs, true)));
       }
 

java/src/org/openqa/selenium/grid/config/AnnotatedConfig.java

@@ -77,11 +77,11 @@ public AnnotatedConfig(Object obj, Set<String> cliArgs, boolean includeCliArgs)
       Parameter cliAnnotation = field.getAnnotation(Parameter.class);
       boolean containsCliArg =
           cliAnnotation != null && Arrays.stream(cliAnnotation.names()).anyMatch(cliArgs::contains);
-      if (cliArgs.size() > 0 && !containsCliArg && includeCliArgs) {
+      if (!cliArgs.isEmpty() && !containsCliArg && includeCliArgs) {
         // Only getting config values for args entered by the user.
         continue;
       }
-      if (cliArgs.size() > 0 && containsCliArg && !includeCliArgs) {
+      if (!cliArgs.isEmpty() && containsCliArg && !includeCliArgs) {
         // Excluding config values for args entered by the user.
         continue;
       }

java/src/org/openqa/selenium/grid/node/config/NodeOptions.java

@@ -507,7 +507,7 @@ private void addDetectedDrivers(
               sessionFactories.putAll(capabilities, entry.getValue());
             });
 
-    if (sessionFactories.build().size() == 0) {
+    if (sessionFactories.build().isEmpty()) {
       String logMessage = "No drivers have been configured or have been found on PATH";
       LOG.warning(logMessage);
       throw new ConfigException(logMessage);

java/src/org/openqa/selenium/remote/TracedCommandExecutor.java

@@ -42,7 +42,7 @@ public Response execute(Command command) throws IOException {
       }
       commandSpan.setAttribute("command", command.getName());
       Map<String, ?> parameters = command.getParameters();
-      if (parameters != null && parameters.size() > 0) {
+      if (parameters != null && !parameters.isEmpty()) {
         for (Map.Entry<String, ?> parameter : parameters.entrySet()) {
           commandSpan.setAttribute(
               "parameter." + parameter.getKey(), Objects.toString(parameter.getValue(), "null"));

java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java

@@ -393,7 +393,7 @@ private Map<String, String> asElement(Object id) {
 
   private String cssEscape(String using) {
     using = CSS_ESCAPE.matcher(using).replaceAll("\\\\$1");
-    if (using.length() > 0 && Character.isDigit(using.charAt(0))) {
+    if (!using.isEmpty() && Character.isDigit(using.charAt(0))) {
       using = "\\" + (30 + Integer.parseInt(using.substring(0, 1))) + " " + using.substring(1);
     }
     return using;

java/src/org/openqa/selenium/support/pagefactory/AjaxElementLocator.java

@@ -195,7 +195,7 @@ protected long sleepFor() {
     protected void isLoaded() throws Error {
       try {
         elements = AjaxElementLocator.super.findElements();
-        if (elements.size() == 0) {
+        if (elements.isEmpty()) {
           throw new NoSuchElementException("Unable to locate the element");
         }
         for (WebElement element : elements) {

java/src/org/openqa/selenium/support/ui/ExpectedConditions.java

@@ -224,7 +224,7 @@ public List<WebElement> apply(WebDriver driver) {
             return null;
           }
         }
-        return elements.size() > 0 ? elements : null;
+        return !elements.isEmpty() ? elements : null;
       }
 
       @Override
@@ -265,7 +265,7 @@ public List<WebElement> apply(WebDriver driver) {
             return null;
           }
         }
-        return elements.size() > 0 ? elements : null;
+        return !elements.isEmpty() ? elements : null;
       }
 
       @Override
@@ -316,7 +316,7 @@ public static ExpectedCondition<List<WebElement>> presenceOfAllElementsLocatedBy
       @Override
       public List<WebElement> apply(WebDriver driver) {
         List<WebElement> elements = driver.findElements(locator);
-        return elements.size() > 0 ? elements : null;
+        return !elements.isEmpty() ? elements : null;
       }
 
       @Override

java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java

@@ -142,7 +142,7 @@ void canCast() {
     List<Map<String, String>> castSinks = caster.getCastSinks();
 
     // Can not call these commands if there are no sinks available
-    if (castSinks.size() > 0) {
+    if (!castSinks.isEmpty()) {
       String deviceName = castSinks.get(0).get("name");
 
       caster.startTabMirroring(deviceName);
@@ -161,7 +161,7 @@ public void canCastOnDesktop() {
     List<Map<String, String>> castSinks = caster.getCastSinks();
 
     // Can not call these commands if there are no sinks available
-    if (castSinks.size() > 0) {
+    if (!castSinks.isEmpty()) {
       String deviceName = castSinks.get(0).get("name");
 
       caster.startDesktopMirroring(deviceName);

java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java

@@ -151,7 +151,7 @@ void canCast() throws InterruptedException {
     List<Map<String, String>> castSinks = caster.getCastSinks();
 
     // Can not call these commands if there are no sinks available
-    if (castSinks.size() > 0) {
+    if (!castSinks.isEmpty()) {
       String deviceName = castSinks.get(0).get("name");
 
       caster.startTabMirroring(deviceName);

java/test/org/openqa/selenium/grid/distributor/DistributorDrainingTest.java

@@ -169,7 +169,7 @@ private void waitTillNodesAreRemoved(Distributor distributor) {
         .until(
             d -> {
               Set<NodeStatus> nodes = d.getStatus().getNodes();
-              return nodes.size() == 0;
+              return nodes.isEmpty();
             });
   }