Skip to content

Commit 1ecfb88

Browse files
committed
[javascript] Tracking SM language binding in JavaScript
Helps with #13288
1 parent 793a5e4 commit 1ecfb88

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

javascript/node/selenium-webdriver/common/seleniumManager.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ let debugMessagePrinted = false
3535
* Determines the path of the correct Selenium Manager binary
3636
* @returns {string}
3737
*/
38-
function getBinary() {
38+
function getBinary () {
3939
const directory = {
4040
darwin: 'macos',
4141
win32: 'windows',
@@ -48,7 +48,8 @@ function getBinary() {
4848

4949
let seleniumManagerBasePath = path.join(__dirname, '..', '/bin')
5050

51-
const filePath = process.env.SE_MANAGER_PATH || path.join(seleniumManagerBasePath, directory, file)
51+
const filePath = process.env.SE_MANAGER_PATH || path.join(
52+
seleniumManagerBasePath, directory, file)
5253

5354
if (!fs.existsSync(filePath)) {
5455
throw new Error(`Unable to obtain Selenium Manager at ${filePath}`)
@@ -69,8 +70,9 @@ function getBinary() {
6970
* browser location
7071
*/
7172

72-
function driverLocation(options) {
73-
let args = ['--browser', options.getBrowserName(), '--output', 'json']
73+
function driverLocation (options) {
74+
let args = ['--browser', options.getBrowserName(), '--language-binding',
75+
'javascript', '--output', 'json']
7476

7577
if (options.getBrowserVersion() && options.getBrowserVersion() !== '') {
7678
args.push('--browser-version', options.getBrowserVersion())
@@ -139,7 +141,7 @@ function driverLocation(options) {
139141
}
140142
}
141143

142-
function logOutput(output) {
144+
function logOutput (output) {
143145
for (const key in output.logs) {
144146
if (output.logs[key].level === 'WARN') {
145147
log_.warning(`${output.logs[key].message}`)

0 commit comments

Comments
 (0)