[rb] Update rules_ruby to the latest version (#13235)

Notably, it now allows to read version from `.ruby-version` file and use
a more convenient `run_binary()` rule instead of a `genrule()`.

The commit also bumps supported Ruby versions on CI.

Author: p0deje

.github/workflows/bazel.yml

@@ -70,10 +70,10 @@ jobs:
       - name: Remove driver directories Non-Windows
         if: inputs.os != 'windows'
         run: |
-          sudo rm -rf $CHROMEWEBDRIVER $EDGEWEBDRIVER $GECKOWEBDRIVER
+          sudo rm -rf "$CHROMEWEBDRIVER" "$EDGEWEBDRIVER" "$GECKOWEBDRIVER"
       - name: Set Ruby version
         if: inputs.ruby-version != ''
-        run: echo 'RUBY_VERSION = "${{ inputs.ruby-version }}"' > rb/ruby_version.bzl
+        run: echo '${{ inputs.ruby-version }}' > rb/.ruby-version
       - name: Setup Java
         if: inputs.java-version != ''
         uses: actions/setup-java@v3
@@ -84,6 +84,7 @@ jobs:
         uses: p0deje/[email protected]
         with:
           bazelisk-cache: true
+          bazelrc: common --color=yes
           disk-cache: ${{ inputs.cache-key }}
           external-cache: |
             name: ${{ inputs.cache-key }}
@@ -99,7 +100,7 @@ jobs:
           sudo apt-get -y install fluxbox
           Xvfb :99 &
           fluxbox -display :99 &
-          echo "DISPLAY=:99" >> $GITHUB_ENV
+          echo "DISPLAY=:99" >> "$GITHUB_ENV"
       - name: Set resolution
         if: inputs.os == 'windows' && inputs.browser != ''
         run: Set-DisplayResolution -Width 1920 -Height 1080 -Force

.github/workflows/ci-ruby.yml

@@ -43,13 +43,13 @@ jobs:
             os: ubuntu
           - ruby-version: 3.0.6
             os: windows
-          - ruby-version: 3.2.0
-            os: ubuntu
-          - ruby-version: 3.2.0
+          - ruby-version: 3.0.6
             os: macos
-          - ruby-version: jruby-9.4.3.0
+          - ruby-version: 3.2.2
+            os: ubuntu
+          - ruby-version: jruby-9.4.5.0
             os: ubuntu
-          - ruby-version: truffleruby-22.3.0
+          - ruby-version: truffleruby-23.1.1
             os: ubuntu
     with:
       name: Unit Tests (${{ matrix.ruby-version }}, ${{ matrix.os }})

.gitignore

@@ -99,7 +99,6 @@ ipch/
 geckodriver.log
 ghostdriver.log
 .tags
-.ruby-version
 GPATH
 GRTAGS
 GSYMS

README.md

@@ -260,9 +260,10 @@ Supported environment variables:
 - `EDGE_BINARY` - path to test specific Edge browser
 - `FIREFOX_BINARY` - path to test specific Firefox browser
 
-To run with a specific version of Ruby you can change the version in `rb/ruby_version.bzl` or from command line:
+To run with a specific version of Ruby you can change the version in `rb/.ruby-version` or from command line:
+
 ```sh
-echo 'RUBY_VERSION = "<X.Y.Z>"' > rb/ruby_version.bzl
+echo '<X.Y.Z>' > rb/.ruby-version
 ```
 
 If you want to debug code in tests, you can do it via [`debug`](https://github.com/ruby/debug) gem:

WORKSPACE

@@ -327,19 +327,18 @@ pin_browsers()
 
 http_archive(
     name = "rules_ruby",
-    sha256 = "92055f29f94963cd3cf7be1da15503c3306879e2e8545b2b5f9e5bb37d6713d3",
-    strip_prefix = "rules_ruby-0.2.0",
-    url = "https://github.com/p0deje/rules_ruby/releases/download/v0.2.0/rules_ruby-v0.2.0.tar.gz",
+    sha256 = "e3495d0129222572654cc5dd5c72c6c997513d65fb8649f43a860ab15334a1c2",
+    strip_prefix = "rules_ruby-0.4.1",
+    url = "https://github.com/bazel-contrib/rules_ruby/releases/download/v0.4.1/rules_ruby-v0.4.1.tar.gz",
 )
 
 load(
     "@rules_ruby//ruby:deps.bzl",
     "rb_bundle",
     "rb_register_toolchains",
 )
-load("//rb:ruby_version.bzl", "RUBY_VERSION")
 
-rb_register_toolchains(version = RUBY_VERSION)
+rb_register_toolchains(version_file = "//:rb/.ruby-version")
 
 rb_bundle(
     name = "bundle",

rb/.ruby-version

@@ -0,0 +1 @@
+3.0.6

rb/BUILD.bazel

@@ -12,8 +12,6 @@ package(default_visibility = ["//:__subpackages__"])
 
 GITHUB_PACKAGES_HOST = "https://rubygems.pkg.github.com/SeleniumHQ"
 
-exports_files(["ruby_version.bzl"])
-
 copy_file(
     name = "manager-linux",
     src = "//common/manager:selenium-manager-linux",

rb/Gemfile.lock

@@ -45,11 +45,9 @@ GEM
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     io-console (0.6.0)
-    io-console (0.6.0-java)
     irb (1.9.0)
       rdoc
       reline (>= 0.3.8)
-    jar-dependencies (0.4.1)
     json (2.6.3)
     json (2.6.3-java)
     language_server-protocol (3.17.0.3)
@@ -65,8 +63,6 @@ GEM
       racc
     psych (5.1.1.1)
       stringio
-    psych (5.1.1.1-java)
-      jar-dependencies (>= 0.1.7)
     public_suffix (5.0.4)
     racc (1.7.3)
     racc (1.7.3-java)

rb/lib/selenium/devtools/BUILD.bazel

@@ -1,4 +1,5 @@
-load("@rules_ruby//ruby:defs.bzl", "rb_library")
+load("@bazel_skylib//rules:run_binary.bzl", "run_binary")
+load("@rules_ruby//ruby:defs.bzl", "rb_binary", "rb_library")
 
 package(default_visibility = ["//rb:__subpackages__"])
 
@@ -20,30 +21,35 @@ rb_library(
     srcs = ["version.rb"],
 )
 
-rb_library(
+rb_binary(
     name = "cdp-generate",
     srcs = ["support/cdp_client_generator.rb"],
-)
-
-filegroup(
-    name = "cdp-generate-file",
-    srcs = ["support/cdp_client_generator.rb"],
+    data = [
+        "support/cdp/domain.rb.erb",
+        "support/cdp/loader.rb.erb",
+    ],
+    main = "support/cdp_client_generator.rb",
 )
 
 [
-    genrule(
-        name = "cdp-" + n,
+    run_binary(
+        name = "cdp-" + version,
         srcs = [
-            "//common/devtools/chromium/" + n + ":browser_protocol",
-            "//common/devtools/chromium/" + n + ":js_protocol",
-            ":cdp-generate-file",
+            "//common/devtools/chromium/" + version + ":browser_protocol",
+            "//common/devtools/chromium/" + version + ":js_protocol",
         ],
         outs = [
-            n,
-            n + ".rb",
+            version,
+            version + ".rb",
+        ],
+        args = [
+            "$(location //common/devtools/chromium/" + version + ":browser_protocol)",
+            "$(location //common/devtools/chromium/" + version + ":js_protocol)",
+            "$(location :" + version + ")/",
+            "$(location :" + version + ".rb)",
+            version,
         ],
-        cmd = "$(location @rules_ruby_dist//:ruby) $(location :cdp-generate-file) $(location //common/devtools/chromium/" + n + ":browser_protocol) $(location //common/devtools/chromium/" + n + ":js_protocol) $(OUTS) " + n,
-        tools = ["@rules_ruby_dist//:ruby"],
+        tool = ":cdp-generate",
     )
-    for n in CDP_VERSIONS
+    for version in CDP_VERSIONS
 ]