Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow streaming for O1 model family #902

Closed
wants to merge 2 commits into from
Closed

Allow streaming for O1 model family #902

wants to merge 2 commits into from

Conversation

handsomefox
Copy link

Describe the change
Don't return error if streaming is enable for o1 model family.

Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/streaming

Additional context
https://x.com/OpenAIDevs/status/1858609150999359559

Signed-off-by: Eduard Diachenko <handsomefox.hf@gmail.com>
@sashabaranov
Copy link
Owner

@handsomefox thank you for the PR! Please the latest changes from master here, so the CI will pass

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (774fc9d) to head (2b1abae).
Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
+ Coverage   98.46%   98.69%   +0.23%     
==========================================
  Files          24       26       +2     
  Lines        1364     1758     +394     
==========================================
+ Hits         1343     1735     +392     
- Misses         15       16       +1     
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sashabaranov
Copy link
Owner

@handsomefox Sorry, I ended up merging the other PR. But thanks again for the links — really helpful to get full context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants