Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving pt-BR translation #1865

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Improving pt-BR translation #1865

merged 1 commit into from
Dec 27, 2018

Conversation

lucianosousa
Copy link
Contributor

Add couple missing translations

@lucianosousa
Copy link
Contributor Author

@nettofarah can you take a look, please?

nettofarah
nettofarah approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left some tiny suggestions, but I guess that’s a matter of how strict we want to be. Either way should be fine.

Thanks, and great PR

@lucianosousa
Copy link
Contributor Author

@nettofarah updated. let me know if looks good! ;) thanks for the review

nettofarah
nettofarah approved these changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome.
:shipit:

@lucianosousa
Copy link
Contributor Author

@sonalkr132 reviewed

@sonalkr132 sonalkr132 merged commit d139c29 into rubygems:master Dec 27, 2018
@sonalkr132
Copy link
Member

Thanks @lucianosousa @nettofarah 🗺️

@rubygems-deployer rubygems-deployer temporarily deployed to staging December 27, 2018 04:41 Inactive
@lucianosousa lucianosousa deleted the pt-br-improve branch December 27, 2018 16:40
@sonalkr132 sonalkr132 temporarily deployed to production December 28, 2018 15:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nettofarah nettofarah nettofarah approved these changes

Assignees
No one assigned
Labels
needs-i18n-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucianosousa @sonalkr132 @nettofarah @rubygems-deployer