Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flipper for feature flags #5851

Merged

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented Jun 21, 2024

I've added the flipper gem (https://www.flippercloud.io/docs) for managing feature toggles. I also put in flipper-ui for a nice web based interface for flipper that you can access at /flipper.

To do so, you need to have environment variables set for FLIPPER_USERNAME and FLIPPER_PASSWORD. You can set these in your .env file.

The defaults in QA will be username: admin and password: password. Production credentials will differ.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 21, 2024
@elasticspoon elasticspoon force-pushed the feat/add-feature-flags-via-flipper branch from 4c2a023 to 3651d38 Compare June 21, 2024 17:45
@compwron
Copy link
Collaborator

Nice. Do keep in mind that we have an existing handrolled feature flag system that you should unify at some point

@elasticspoon elasticspoon force-pushed the feat/add-feature-flags-via-flipper branch from 3651d38 to 0ca1abd Compare June 22, 2024 02:09
@elasticspoon
Copy link
Collaborator Author

I think I would also roll the fund request logic in, since there is not user facing way to toggle them.

@elasticspoon elasticspoon marked this pull request as ready for review June 23, 2024 01:31
@elasticspoon elasticspoon merged commit ddaef84 into rubyforgood:main Jun 26, 2024
15 of 17 checks passed
@elasticspoon elasticspoon deleted the feat/add-feature-flags-via-flipper branch July 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants